From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, bruce.w.allan@intel.com
Subject: Re: [net-2.6 PATCH 5/5] e1000e: allow for swflag to be held over consecutive PHY accesses
Date: Mon, 26 Oct 2009 16:17:27 -0700 (PDT) [thread overview]
Message-ID: <20091026.161727.75083296.davem@davemloft.net> (raw)
In-Reply-To: <20091026212401.9682.51970.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 26 Oct 2009 14:24:02 -0700
> From: Bruce Allan <bruce.w.allan@intel.com>
>
> PCH-based parts (82577/82578) and some ICH8-based parts (82566) need to
> hold the swflag (sw/fw/hw hardware semaphore) over consecutive PHY accesses
> in order to perform sw-driven PHY configuration during initialization to
> workaround known hardware issues (see follow-on patch). This patch
> provides new PHY read/write functions (and function pointers) that will
> allow accessing the PHY registers assuming the swflag has already been
> acquired. The actual PHY register access code has moved into helper
> functions that are called with a flag indicating whether or not the swflag
> has already been acquired and acquires/releases it if not.
>
> The functions called from within the updated PHY access functions had to be
> updated to assume the swflag was already acquired, and other functions that
> called those functions were also updated to acquire/release the swflag.
>
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2009-10-26 23:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 21:22 [net-2.6 PATCH 1/5] e1000e: clear PHY wakeup bit after LCD reset on 82577/82578 Jeff Kirsher
2009-10-26 21:23 ` [net-2.6 PATCH 2/5] e1000e: increase swflag acquisition timeout for ICHx/PCH Jeff Kirsher
2009-10-26 23:17 ` David Miller
2009-10-26 21:23 ` [net-2.6 PATCH 3/5] e1000e: 82577/82578 requires a different method to configure LPLU Jeff Kirsher
2009-10-26 23:17 ` David Miller
2009-10-26 21:23 ` [net-2.6 PATCH 4/5] e1000e: separate mutex usage between NVM and PHY/CSR register for ICHx/PCH Jeff Kirsher
2009-10-26 23:17 ` David Miller
2009-10-26 21:24 ` [net-2.6 PATCH 5/5] e1000e: allow for swflag to be held over consecutive PHY accesses Jeff Kirsher
2009-10-26 23:17 ` David Miller [this message]
2009-10-26 23:17 ` [net-2.6 PATCH 1/5] e1000e: clear PHY wakeup bit after LCD reset on 82577/82578 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026.161727.75083296.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bruce.w.allan@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).