From: David Miller <davem@davemloft.net>
To: bcrl@lhnet.ca
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH] fib_hash: improve route deletion scaling on interface drop with lots of interfaces
Date: Tue, 27 Oct 2009 18:01:04 -0700 (PDT) [thread overview]
Message-ID: <20091027.180104.135164582.davem@davemloft.net> (raw)
In-Reply-To: <20091027142426.GB3141@kvack.org>
From: Benjamin LaHaise <bcrl@lhnet.ca>
Date: Tue, 27 Oct 2009 10:24:26 -0400
> On Mon, Oct 26, 2009 at 05:17:49PM -0700, David Miller wrote:
>> > bottleneck. Next up in the network code is rt_cache_flush(). Comments?
>>
>> On a real router adding and removing routes is happening a lot
>> whereas interface changes are rare. You're making a more common
>> operation more expensive for the sake of a less common one.
>
> It's not a question of more common vs less common, but if the system can
> recover from an adverse event within a reasonable amount of time. Tunnel
> flaps occur in the real world, and this results in the change of state of
> a large number of interfaces at the same time. Would it be okay if this
> is wrapped in a config option? I agree that the extra overhead is not
> for everyone.
Having it in a config option is worse, distributions are going
to turn it on so it would be protecting nothing for %99.999 of
folks out there.
next prev parent reply other threads:[~2009-10-28 1:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 0:03 [RFC PATCH] fib_hash: improve route deletion scaling on interface drop with lots of interfaces Benjamin LaHaise
2009-10-27 0:17 ` David Miller
2009-10-27 14:24 ` Benjamin LaHaise
2009-10-28 1:01 ` David Miller [this message]
2009-10-27 0:24 ` Stephen Hemminger
2009-10-27 21:07 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091027.180104.135164582.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcrl@lhnet.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).