From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: akpm@linux-foundation.org, shemminger@linux-foundation.org,
netdev@vger.kernel.org, kolo@albatani.cz,
bugzilla-daemon@bugzilla.kernel.org
Subject: Re: [Bug 14470] New: freez in TCP stack
Date: Wed, 28 Oct 2009 23:02:32 -0700 (PDT) [thread overview]
Message-ID: <20091028.230232.20877138.davem@davemloft.net> (raw)
In-Reply-To: <4AE92F4D.6070101@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 29 Oct 2009 06:59:41 +0100
> David, what do you think of following patch ?
>
> I wonder if we should reorganize code to add sanity checks in tcp_unlink_write_queue()
> that the skb we delete from queue is not still referenced.
>
> [PATCH] tcp: clear retrans hints in tcp_send_synack()
>
> There is a small possibility the skb we unlink from write queue
> is still referenced by retrans hints.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Yes, the first thing I thought of when I saw this crash was the hints.
I'll think this over.
next prev parent reply other threads:[~2009-10-29 6:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 15:41 Fw: [Bug 14470] New: freez in TCP stack Stephen Hemminger
2009-10-28 22:13 ` Andrew Morton
2009-10-28 22:27 ` Denys Fedoryschenko
2009-10-29 5:35 ` Eric Dumazet
2009-10-29 5:59 ` Eric Dumazet
2009-10-29 6:02 ` David Miller [this message]
2009-10-29 8:00 ` David Miller
2009-11-26 21:54 ` Ilpo Järvinen
2009-11-26 23:37 ` David Miller
2009-11-27 6:17 ` Eric Dumazet
2009-12-02 23:10 ` David Miller
2009-12-03 6:24 ` David Miller
2010-03-18 21:04 ` Andrew Morton
2010-03-19 15:52 ` Ilpo Järvinen
2009-10-29 12:58 ` Fw: " Ilpo Järvinen
2009-10-29 14:08 ` Eric Dumazet
2009-10-30 20:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028.230232.20877138.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=eric.dumazet@gmail.com \
--cc=kolo@albatani.cz \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).