* dev_flags definitions in broadcom.c
@ 2009-10-28 21:25 Matt Carlson
0 siblings, 0 replies; only message in thread
From: Matt Carlson @ 2009-10-28 21:25 UTC (permalink / raw)
To: Nate Case; +Cc: Maciej W. Rozycki, Jeff Garzik, netdev@vger.kernel.org
Nate, On May 17, 2008 you submitted a patch titled
"PHYLIB: Add 1000Base-X support for Broadcom bcm5482". In that patch
you defined several dev_flags definitions for the broadcom module. I
only see the PHY_BCM_FLAGS_MODE_1000BX being used in the code though. I
quickly scanned through the phy_connect calls in drivers/net and didn't
see any caller using this preprocessor definition or an equivalent
hardcoded constant. Perhaps I missed something though. Can you tell me
where these flags are set?
My interest in this is several-fold. First, I'd like to move the
definitions to include/linux/brcmphy.h so that the same preprocessor
definitons can be used at both ends. But more important than that, I'd
like to get a handle on how many of these definitions are actually used
and how many are just placeholders. With only 32-bits to use, the flags
might become a precious resource. I have plans for a few of these bits
myself, and I'd like reviewers to take note of how they are used.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-10-28 21:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-28 21:25 dev_flags definitions in broadcom.c Matt Carlson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).