From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: nhorman@tuxdriver.com, netdev@vger.kernel.org
Subject: Re: [PATCH] AF_RAW: Augment raw_send_hdrinc to expand skb to fit iphdr->ihl (v2)
Date: Thu, 29 Oct 2009 01:10:14 -0700 (PDT) [thread overview]
Message-ID: <20091029.011014.222504422.davem@davemloft.net> (raw)
In-Reply-To: <4AE8B114.6050504@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 28 Oct 2009 22:01:08 +0100
> Neil Horman a écrit :
>>
>>> I believe we should drop the request, since padding it is not what was expected by user.
>>
>> Yeah, I had a feeling. Ok, version 2, this time drop the invalid frame and
>> report it to user space, instead of expanding it:
>>
>>
>> Augment raw_send_hdrinc to correct for incorrect ip header length values
...
>> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
Applied to net-2.6, thanks everyone!
prev parent reply other threads:[~2009-10-29 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 17:39 [PATCH] AF_RAW: Augment raw_send_hdrinc to expand skb to fit iphdr->ihl Neil Horman
2009-10-28 18:13 ` Eric Dumazet
2009-10-28 18:59 ` [PATCH] AF_RAW: Augment raw_send_hdrinc to expand skb to fit iphdr->ihl (v2) Neil Horman
2009-10-28 21:01 ` Eric Dumazet
2009-10-29 8:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029.011014.222504422.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).