From: David Miller <davem@davemloft.net>
To: gorcunov@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] net,socket: introduce build_sockaddr_check helper to catch overflow at build time
Date: Thu, 29 Oct 2009 03:00:19 -0700 (PDT) [thread overview]
Message-ID: <20091029.030019.44832583.davem@davemloft.net> (raw)
In-Reply-To: <20091024163226.GA5204@lenovo>
From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Sat, 24 Oct 2009 20:32:26 +0400
> net,socket: introduce DECLARE_SOCKADDR helper to catch overflow at build time
>
> proto_ops->getname implies copying protocol specific data
> into storage unit (particulary to __kernel_sockaddr_storage).
> So when we implement new protocol support we should keep such
> a detail in mind (which is easy to forget about).
>
> Lets introduce DECLARE_SOCKADDR helper which check if
> storage unit is not overfowed at build time.
>
> Eventually inet_getname is switched to use DECLARE_SOCKADDR
> (to show example of usage).
>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
I like this, applied to net-next-2.6, thanks!
next prev parent reply other threads:[~2009-10-29 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-21 17:07 [RFC] net,socket: introduce build_sockaddr_check helper to catch overflow at build time Cyrill Gorcunov
2009-10-22 11:49 ` David Miller
2009-10-22 13:55 ` Cyrill Gorcunov
2009-10-23 21:43 ` Cyrill Gorcunov
2009-10-24 13:12 ` David Miller
2009-10-24 16:32 ` Cyrill Gorcunov
2009-10-29 10:00 ` David Miller [this message]
2009-10-29 14:50 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029.030019.44832583.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gorcunov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).