From: David Miller <davem@davemloft.net>
To: bphilips@suse.de
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: set carrier off in probe
Date: Thu, 29 Oct 2009 21:38:16 -0700 (PDT) [thread overview]
Message-ID: <20091029.213816.35637194.davem@davemloft.net> (raw)
In-Reply-To: <20091030043050.GB3380@jenkins.home.ifup.org>
From: Brandon Philips <bphilips@suse.de>
Date: Thu, 29 Oct 2009 21:30:50 -0700
> The buglet is that other drivers seem to report "Link detected: no"
> after probe while sky2 doesn't.
I agree that we should report something consistent before interface
up and 'no' is probably the best.
I remember fixing something similar in other drivers a few months
ago.
next prev parent reply other threads:[~2009-10-30 4:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 23:58 [PATCH] sky2: set carrier off in probe Brandon Philips
2009-10-30 3:09 ` Stephen Hemminger
2009-10-30 3:51 ` Brandon Philips
2009-10-30 4:12 ` David Miller
2009-10-30 4:30 ` Brandon Philips
2009-10-30 4:38 ` David Miller [this message]
2009-10-30 15:34 ` Stephen Hemminger
2009-10-30 18:11 ` David Miller
2009-10-30 15:54 ` Herbert Xu
2009-10-30 18:10 ` David Miller
2009-10-30 18:16 ` Herbert Xu
2009-10-30 18:20 ` David Miller
2009-10-30 19:13 ` Herbert Xu
2009-10-30 19:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029.213816.35637194.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@suse.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).