netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch]convert kaweth to use usb_reset_configuration()
@ 2009-10-29 15:07 Oliver Neukum
  2009-10-30  6:07 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Oliver Neukum @ 2009-10-29 15:07 UTC (permalink / raw)
  To: Sarah Sharp, davem, netdev

For USB 3.0 it is necessary that all drivers use the standard
API to reset a configuration. This removes a home-grown
implementation.

Signed-off-by: Oliver Neukum <oliver@neukum.org>

Hi David,

please take this for the next merge window.

	Regards
		Oliver

--

--- a/drivers/net/usb/kaweth.c
+++ b/drivers/net/usb/kaweth.c
@@ -471,16 +471,7 @@ static int kaweth_reset(struct kaweth_device *kaweth)
 	int result;
 
 	dbg("kaweth_reset(%p)", kaweth);
-	result = kaweth_control(kaweth,
-				usb_sndctrlpipe(kaweth->dev, 0),
-				USB_REQ_SET_CONFIGURATION,
-				0,
-				kaweth->dev->config[0].desc.bConfigurationValue,
-				0,
-				NULL,
-				0,
-				KAWETH_CONTROL_TIMEOUT);
-
+	result = usb_reset_configuration(kaweth->dev);
 	mdelay(10);
 
 	dbg("kaweth_reset() returns %d.",result);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch]convert kaweth to use usb_reset_configuration()
  2009-10-29 15:07 [patch]convert kaweth to use usb_reset_configuration() Oliver Neukum
@ 2009-10-30  6:07 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-10-30  6:07 UTC (permalink / raw)
  To: oliver; +Cc: sarah.a.sharp, netdev

From: Oliver Neukum <oliver@neukum.org>
Date: Thu, 29 Oct 2009 16:07:12 +0100

> For USB 3.0 it is necessary that all drivers use the standard
> API to reset a configuration. This removes a home-grown
> implementation.
> 
> Signed-off-by: Oliver Neukum <oliver@neukum.org>
> 
> Hi David,
> 
> please take this for the next merge window.

Applied to net-next-2.6, thanks Oliver.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-30  6:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-29 15:07 [patch]convert kaweth to use usb_reset_configuration() Oliver Neukum
2009-10-30  6:07 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).