From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Brandon Philips <bphilips@suse.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: set carrier off in probe
Date: Thu, 29 Oct 2009 20:09:05 -0700 [thread overview]
Message-ID: <20091029200905.00f4c13d@nehalam> (raw)
In-Reply-To: <20091029235807.GF3228@jenkins.home.ifup.org>
On Thu, 29 Oct 2009 16:58:07 -0700
Brandon Philips <bphilips@suse.de> wrote:
> Before bringing up a sky2 interface up ethtool reports
> "Link detected: yes". Do as ixgbe does and netif_carrier_off() on
> probe().
>
> Signed-off-by: Brandon Philips <bphilips@suse.de>
>
> ---
> drivers/net/sky2.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/net/sky2.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/sky2.c
> +++ linux-2.6/drivers/net/sky2.c
> @@ -4538,6 +4538,8 @@ static int __devinit sky2_probe(struct p
> goto err_out_free_netdev;
> }
>
> + netif_carrier_off(dev);
> +
> netif_napi_add(dev, &hw->napi, sky2_poll, NAPI_WEIGHT);
>
> err = request_irq(pdev->irq, sky2_intr,
IMHO carrier is meaningless until device is up? What software
cares?
--
next prev parent reply other threads:[~2009-10-30 3:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 23:58 [PATCH] sky2: set carrier off in probe Brandon Philips
2009-10-30 3:09 ` Stephen Hemminger [this message]
2009-10-30 3:51 ` Brandon Philips
2009-10-30 4:12 ` David Miller
2009-10-30 4:30 ` Brandon Philips
2009-10-30 4:38 ` David Miller
2009-10-30 15:34 ` Stephen Hemminger
2009-10-30 18:11 ` David Miller
2009-10-30 15:54 ` Herbert Xu
2009-10-30 18:10 ` David Miller
2009-10-30 18:16 ` Herbert Xu
2009-10-30 18:20 ` David Miller
2009-10-30 19:13 ` Herbert Xu
2009-10-30 19:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029200905.00f4c13d@nehalam \
--to=shemminger@linux-foundation.org \
--cc=bphilips@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).