From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: bphilips@suse.de, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: set carrier off in probe
Date: Fri, 30 Oct 2009 11:11:14 -0700 (PDT) [thread overview]
Message-ID: <20091030.111114.119833365.davem@davemloft.net> (raw)
In-Reply-To: <20091030083452.68ca227e@nehalam>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Fri, 30 Oct 2009 08:34:52 -0700
> Why not fix the problem in a generic way?
Drivers still need to make sure carrier is off when their
->open() routine runs, so that the transition event from
link down to link up occurs properly when the device is brought
up.
So mucking around with this carrier test will only hide the
bugs, not make things easier.
next prev parent reply other threads:[~2009-10-30 18:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 23:58 [PATCH] sky2: set carrier off in probe Brandon Philips
2009-10-30 3:09 ` Stephen Hemminger
2009-10-30 3:51 ` Brandon Philips
2009-10-30 4:12 ` David Miller
2009-10-30 4:30 ` Brandon Philips
2009-10-30 4:38 ` David Miller
2009-10-30 15:34 ` Stephen Hemminger
2009-10-30 18:11 ` David Miller [this message]
2009-10-30 15:54 ` Herbert Xu
2009-10-30 18:10 ` David Miller
2009-10-30 18:16 ` Herbert Xu
2009-10-30 18:20 ` David Miller
2009-10-30 19:13 ` Herbert Xu
2009-10-30 19:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030.111114.119833365.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bphilips@suse.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).