From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: francis.moro@gmail.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: WARNING: at net/ipv4/af_inet.c:154 inet_sock_destruct
Date: Fri, 30 Oct 2009 12:26:40 -0700 (PDT) [thread overview]
Message-ID: <20091030.122640.137286305.davem@davemloft.net> (raw)
In-Reply-To: <4AEB0059.1050400@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 30 Oct 2009 16:03:53 +0100
> [PATCH take2] net: fix sk_forward_alloc corruption
>
> On UDP sockets, we must call skb_free_datagram() with socket locked,
> or risk sk_forward_alloc corruption. This requirement is not respected
> in SUNRPC.
>
> Add a convenient helper, skb_free_datagram_locked() and use it in SUNRPC
>
> Reported-by: Francis Moreau <francis.moro@gmail.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
I've tentatively applied this to my net-2.6 tree, I won't
push it out until we have positive testing results.
next prev parent reply other threads:[~2009-10-30 19:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <38b2ab8a0909290109m3f82c161j4fb0f1266152877e@mail.gmail.com>
2009-09-29 9:18 ` WARNING: at net/ipv4/af_inet.c:154 inet_sock_destruct Eric Dumazet
2009-09-29 9:29 ` Francis Moreau
2009-09-30 11:40 ` Francis Moreau
2009-10-30 8:44 ` Francis Moreau
2009-10-30 9:41 ` Eric Dumazet
2009-10-30 11:27 ` Eric Dumazet
2009-10-30 12:33 ` Francis Moreau
2009-10-30 13:41 ` Francis Moreau
2009-10-30 14:55 ` Eric Dumazet
2009-10-30 15:03 ` Eric Dumazet
2009-10-30 19:26 ` David Miller [this message]
2009-10-31 9:20 ` Eric Dumazet
2009-11-06 8:45 ` Francis Moreau
2009-11-06 8:47 ` Eric Dumazet
2009-11-06 8:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030.122640.137286305.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=francis.moro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).