From: Stephen Hemminger <shemminger@vyatta.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Neulinger, Nathan" <nneul@mst.edu>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: How to use gretap with bridge?
Date: Fri, 30 Oct 2009 09:39:57 -0700 [thread overview]
Message-ID: <20091030093957.7128c596@nehalam> (raw)
In-Reply-To: <20091030155148.GA8283@gondor.apana.org.au>
On Fri, 30 Oct 2009 11:51:48 -0400
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Neulinger, Nathan <nneul@mst.edu> wrote:
> >
> > The above change fixes it for me, but I'm no expert on this chunk of
> > code. (Perhaps it it shouldn't set dev_addr at all?)
>
> OK, it was a stupid mistake on my part. I added a netdev ops
> struct for tap but didn't actually use it! Please let us know
> whether this patch fixes the problem.
>
> gre: Fix dev_addr clobbering for gretap
>
> Nathan Neulinger noticed that gretap devices get their MAC address
> from the local IP address, which results in invalid MAC addresses
> half of the time.
>
> This is because gretap is still using the tunnel netdev ops rather
> than the correct tap netdev ops struct.
>
> This patch also fixes changelink to not clobber the MAC address
> for the gretap case.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> Thanks,
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
--
next prev parent reply other threads:[~2009-10-30 16:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <846C5B546E47494CBBD796CA8CA1617EA3B414@MST-VMAIL1.srv.mst.edu>
[not found] ` <20091029170631.GA29405@gondor.apana.org.au>
2009-10-29 18:39 ` How to use gretap with bridge? Neulinger, Nathan
2009-10-29 19:01 ` Neulinger, Nathan
2009-10-29 20:00 ` Stephen Hemminger
2009-10-29 20:22 ` Neulinger, Nathan
2009-10-29 22:12 ` Stephen Hemminger
2009-10-29 22:24 ` [RFC] bridge: check address size Stephen Hemminger
2009-11-02 8:07 ` David Miller
2009-11-02 16:54 ` Stephen Hemminger
2009-11-04 17:47 ` [PATCH] bridge: prevent bridging wrong device Stephen Hemminger
2009-11-06 5:08 ` David Miller
2009-10-29 20:59 ` How to use gretap with bridge? Neulinger, Nathan
2009-10-29 22:04 ` Neulinger, Nathan
2009-10-29 23:47 ` Herbert Xu
2009-10-29 23:51 ` Neulinger, Nathan
2009-10-30 15:51 ` Herbert Xu
2009-10-30 16:39 ` Stephen Hemminger [this message]
2009-10-30 19:27 ` David Miller
2009-10-30 17:08 ` Neulinger, Nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091030093957.7128c596@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=nneul@mst.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).