From: Stephen Hemminger <shemminger@vyatta.com>
To: Naohiro Ooiwa <nooiwa@miraclelinux.com>
Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
jesse.brandeburg@intel.com, john.ronciak@intel.com,
jeffrey.t.kirsher@intel.com,
Andrew Morton <akpm@linux-foundation.org>,
svaidy@linux.vnet.ibm.com, davem@davemloft.net
Subject: Re: [PATCH] e1000: the power down when running ifdown command
Date: Sat, 31 Oct 2009 10:58:38 -0700 [thread overview]
Message-ID: <20091031105838.0d4b59a2@nehalam> (raw)
In-Reply-To: <4AEC05E8.40600@miraclelinux.com>
On Sat, 31 Oct 2009 18:39:52 +0900
Naohiro Ooiwa <nooiwa@miraclelinux.com> wrote:
> Hi All
>
> I resend my patch.
> Sorry, my previous mail lacked an explanation.
>
>
> The e1000 driver doesn't let the power down when running ifdown command.
> So, I set to the D3hot state of a PCI device at the end of e1000_close().
>
> With this modification, e1000 driver reduces power by ifdown.
> It's about 6 watts when I measured a total power of one server machine
> in my environment.
>
> I tested this patch. The result is good enough to me.
>
> Could you please check my patch ?
> If I should have other considerations, please tell me.
>
Does this work with Wake On Lan?
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
next prev parent reply other threads:[~2009-10-31 17:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 9:39 [PATCH] e1000: the power down when running ifdown command Naohiro Ooiwa
2009-10-31 17:58 ` Stephen Hemminger [this message]
2009-11-02 1:28 ` Naohiro Ooiwa
2009-11-04 10:23 ` Naohiro Ooiwa
2009-11-04 16:08 ` Stephen Hemminger
2009-11-04 17:57 ` [E1000-devel] " Allan, Bruce W
2009-11-05 14:58 ` Naohiro Ooiwa
2009-11-03 0:26 ` Jeff Kirsher
2009-11-03 0:56 ` Dan Williams
2009-11-03 10:06 ` Naohiro Ooiwa
2009-11-03 21:37 ` Jeff Kirsher
2009-11-04 10:27 ` Naohiro Ooiwa
-- strict thread matches above, loose matches on Subject: below --
2009-10-23 10:29 Naohiro Ooiwa
2009-10-21 9:52 Naohiro Ooiwa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091031105838.0d4b59a2@nehalam \
--to=shemminger@vyatta.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nooiwa@miraclelinux.com \
--cc=svaidy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).