From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ebiederm@xmission.com, netdev@vger.kernel.org, xemul@openvz.org
Subject: Re: [PATCH net-next-2.6] veth: Fix unregister_netdevice_queue for veth
Date: Sun, 01 Nov 2009 23:56:31 -0800 (PST) [thread overview]
Message-ID: <20091101.235631.218735260.davem@davemloft.net> (raw)
In-Reply-To: <4AEC0653.8050109@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 31 Oct 2009 10:41:39 +0100
> Eric W. Biederman a écrit :
>> I tested the recent unregister many changes and got a weird,
>> nasty and seemingly unrelasted kernel oops. Changing
>> unregister_netdevice_queue to use list_move_tail fixes
>> the problem for me.
>>
>> ip link add type veth
>> rmmod veth
>>
>> ls /sys/class/net/
>> showed one of the veth devices still present.
>>
>> A subsequent ip link oopsed the box.
>>
>> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
...
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2009-11-02 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 7:00 [PATCH net-next-2.6] veth: Fix veth_dellink method Eric Dumazet
2009-10-30 8:00 ` David Miller
2009-10-30 23:07 ` Eric W. Biederman
2009-10-31 0:51 ` [PATCH net-next-2.6] veth: Fix unregister_netdevice_queue for veth Eric W. Biederman
2009-10-31 9:41 ` Eric Dumazet
2009-11-02 7:56 ` David Miller [this message]
2009-10-31 9:43 ` [PATCH net-next-2.6] veth: Fix veth_dellink method Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091101.235631.218735260.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).