From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] iproute2: Avoid rounding errors for 100%. Date: Tue, 3 Nov 2009 09:07:52 -0800 Message-ID: <20091103090752.5b462128@nehalam> References: <1257262694-16985-1-git-send-email-hannemann@nets.rwth-aachen.de> <4AF05821.60303@nets.rwth-aachen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , Arnd Hannemann To: Arnd Hannemann Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:51613 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbZKCRIa (ORCPT ); Tue, 3 Nov 2009 12:08:30 -0500 In-Reply-To: <4AF05821.60303@nets.rwth-aachen.de> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 03 Nov 2009 17:19:45 +0100 Arnd Hannemann wrote: > Although the patch makes sense, > it does not fix the bug/effect we were seeing. > A netem reorder percentage of 100% will still get packets reordered. > (if the netem queue is not empty) > > > hannemann@nets.rwth-aachen.de wrote: > > From: Arnd Hannemann > > > > We noticed that a netem reorder percentage of 100% will still get packets reordered. > > This patch fixes that. > > > > Signed-off-by: Arnd Hannemann > > --- > > tc/tc_util.c | 6 ++++-- > > 1 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/tc/tc_util.c b/tc/tc_util.c > > index fe2c7eb..2641f2e 100644 > > --- a/tc/tc_util.c > > +++ b/tc/tc_util.c > > @@ -363,8 +363,10 @@ int get_percent(__u32 *percent, const char *str) > > return -1; > > if (*p && strcmp(p, "%")) > > return -1; > > - > > - *percent = (unsigned) rint(per * max_percent_value); > > + if (per == 1.) > > + *percent = max_percent_value; > > + else > > + *percent = (unsigned) rint(per * max_percent_value); > > return 0; > > } > > > > If you don't want reordering, don't specify reordering? --