From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: david-b@pacbell.net, greg@kroah.com, jacmet@sunsite.dk,
steve.glendinning@smsc.com, netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: Do not implement ethtool get_link() if link state is unknown
Date: Wed, 04 Nov 2009 00:36:05 -0800 (PST) [thread overview]
Message-ID: <20091104.003605.202776578.davem@davemloft.net> (raw)
In-Reply-To: <1257304800.3136.452.camel@localhost>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Wed, 04 Nov 2009 03:20:00 +0000
> I don't see how it's 'perfect' since it reports the link as up where it
> is really unknown. Still, this is a fairly minor bug.
That is the policy we enforce for all drivers, especially virtual
ones. If you can't tell, you specify that the link is up.
Otherwise automated tools like NetworkManager et al. will not even
attempt to bring do DHCP and bring the network device online.
prev parent reply other threads:[~2009-11-04 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 3:26 [PATCH] usbnet: Do not implement ethtool get_link() if link state is unknown Ben Hutchings
2009-11-03 6:01 ` David Brownell
2009-11-03 9:01 ` David Miller
2009-11-03 9:41 ` David Brownell
2009-11-03 10:04 ` David Miller
2009-11-04 3:20 ` Ben Hutchings
2009-11-04 8:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104.003605.202776578.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=jacmet@sunsite.dk \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).