netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gilad@codefidence.com
Cc: Valdis.Kletnieks@vt.edu, netdev@vger.kernel.org,
	ori@comsleep.com, linux-kernel@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH testing] Do not call IPv4 specific func in tcp_check_req
Date: Wed, 04 Nov 2009 23:22:14 -0800 (PST)	[thread overview]
Message-ID: <20091104.232214.23355826.davem@davemloft.net> (raw)
In-Reply-To: <1257352854-19490-1-git-send-email-gilad@codefidence.com>

From: Gilad Ben-Yossef <gilad@codefidence.com>
Date: Wed,  4 Nov 2009 18:40:54 +0200

> Calling IPv4 specific inet_csk_route_req in tcp_check_req
> is a bad idea and crashes machine on IPv6 connections, as reported
> by Valdis Kletnieks
> 
> Also, all we are really interested in is the timestamp
> option in the header, so calling tcp_parse_options()
> with the "estab" set to false flag is an overkill as
> it tries to parse half a dozen other TCP options.
> 
> We know whether timestamp should be enabled or not
> using data from request_sock.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com>

Applied, thanks.

I assume that your other patch which attempted to fix this isn't
necessary.

  reply	other threads:[~2009-11-05  7:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03 17:50 2.6.32-rc5-mmotm1101 - kernel BUG at net/ipv4/tcp_input.c:3707! Valdis.Kletnieks
2009-11-03 18:02 ` Eric Dumazet
2009-11-03 19:20   ` Gilad Ben-Yossef
2009-11-03 21:34     ` Ilpo JÀrvinen
2009-11-04  2:01       ` Valdis.Kletnieks
2009-11-04  2:34         ` David Miller
2009-11-04  6:38         ` Gilad Ben-Yossef
2009-11-04 16:40         ` [PATCH testing] Do not call IPv4 specific func in tcp_check_req Gilad Ben-Yossef
2009-11-05  7:22           ` David Miller [this message]
2009-11-04 16:43         ` 2.6.32-rc5-mmotm1101 - kernel BUG at net/ipv4/tcp_input.c:3707! Gilad Ben-Yossef
2009-11-05  2:33           ` Valdis.Kletnieks
2009-11-05  7:25             ` David Miller
2009-11-05  7:22           ` David Miller
2009-11-04  6:27       ` Gilad Ben-Yossef
2009-11-03 19:21   ` [PATCH 1/1] Use defaults when no route options are available Gilad Ben-Yossef
2009-11-04 13:28     ` David Miller
2009-11-04 14:27       ` Gilad Ben-Yossef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091104.232214.23355826.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=gilad@codefidence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ori@comsleep.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).