From: Ingo Molnar <mingo@elte.hu>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Randy Dunlap <rdunlap@xenotime.net>,
Luis Correia <luis.f.correia@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
Jarek Poplawski <jarkao2@gmail.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
David Miller <davem@davemloft.net>
Subject: Re: [announce] new rt2800 drivers for Ralink wireless & project tree
Date: Wed, 4 Nov 2009 09:37:37 +0100 [thread overview]
Message-ID: <20091104083737.GA16978@elte.hu> (raw)
In-Reply-To: <200911032200.04516.IvDoorn@gmail.com>
* Ivo van Doorn <ivdoorn@gmail.com> wrote:
> > MAINTAINERS: add rt2800 entry
>
> I see you decided to take over the maintainership? Doesn't that need
> the current maintainer to move away, or was this part of the "going
> over other peoples head" plan?
>
> [...]
>
> These are too much (and too big) patches for me to review at once,
> I'll look at them later.
Frankly, having read through the recent discussions related to the
rt2800pci/usb drivers, the subtle (and largely undeserved) group
violence and abuse you are inflicting on Bart is stomach-turning.
The non-working rt2800pci driver has been pending in your private tree
for how long, 1.5 _years_?
Look at the diffstat of Bart's driver:
15 files changed, 4036 insertions(+), 7158 deletions(-)
He reduced your 5.2 KLOC non-working driver into a 1.8 KLOC _working_
driver.
And _still_ your complaint about Bart's series is that he updated the
MAINTAINERS entry and added an entry for rt2800? Heck _sure_ he should
update it, he is the one doing the hard work of trying to bring it to
users, trying to clean up a messy driver space, trying to turn crap into
gold.
The thing is, if you dont have the time or interest to listen to and act
upon review feedback, be constructive about it and fix (obvious)
structural problems in your rt2800 code, you should just step aside and
let Bart maintain what he is apparently more capable of maintaining than
you are.
What you are doing here is a thinly veiled land-grab: you did a minimal
token driver for rt2800 that doesnt work, kept it in your private tree
for _1.5 years_, and the moment someone _else_ came along and did
something better and more functional in drivers/staging/, you discovered
your sudden interest for it and moved the crappy driver upstream at
lightning's speed (it is already in net-next AFAICS, despite negative
test and review feedback) - ignoring and throwing away all the work that
Bart has done.
Such behavior wouldnt fly in _any_ other Linux subsystem, but apparently
there is one set of rules for upstream kernel maintainers and then
there's another, different set of rules for upstream wireless driver
maintainers.
Really, you should listen to contrary opinion and _you_ should work
_hard_ to integrate Bart socially and open up your close circle of
wireless insiders instead of fighting his 'outsider' contributions every
which way. We dont care if people are rough, express displeasure and
show strong opinion about crappy code - but the moment you are
_excluding_ capable people and playing petty office politics (like you
are very clearly doing it with Bart here) everyone loses.
Guys, show some minimal amount of honesty, openness and critical
thinking please ...
Ingo
next prev parent reply other threads:[~2009-11-04 8:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 18:51 [announce] new rt2800 drivers for Ralink wireless & project tree Bartlomiej Zolnierkiewicz
2009-11-03 21:00 ` Ivo van Doorn
2009-11-03 21:44 ` Bartlomiej Zolnierkiewicz
2009-11-03 22:01 ` Ivo van Doorn
2009-11-03 22:34 ` Bartlomiej Zolnierkiewicz
2009-11-03 23:09 ` Gertjan van Wingerde
2009-11-03 23:46 ` Bartlomiej Zolnierkiewicz
[not found] ` <200911040046.54247.bzolnier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-04 1:33 ` Julian Calaby
2009-11-04 2:28 ` Bartlomiej Zolnierkiewicz
[not found] ` <200911032334.40547.bzolnier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-03 23:48 ` Alan Cox
2009-11-03 23:52 ` Bartlomiej Zolnierkiewicz
2009-11-04 0:40 ` Alan Cox
2009-11-04 0:48 ` Bartlomiej Zolnierkiewicz
2009-11-04 8:37 ` Ingo Molnar [this message]
[not found] ` <20091104083737.GA16978-X9Un+BFzKDI@public.gmane.org>
2009-11-04 14:38 ` John W. Linville
2009-11-04 21:51 ` Ivo van Doorn
[not found] ` <200911042251.23506.IvDoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-04 22:12 ` John W. Linville
2009-11-06 7:46 ` Pavel Machek
2009-11-06 17:58 ` Ivo van Doorn
[not found] ` <200911061858.56816.IvDoorn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-06 18:30 ` Bartlomiej Zolnierkiewicz
2009-11-06 18:59 ` John W. Linville
2009-11-07 17:30 ` Pavel Machek
2009-11-07 18:12 ` Luis Correia
[not found] ` <efe7343f0911071012u73317883wc60f5c188bc853e8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-07 18:31 ` Ivo van Doorn
2009-11-07 19:43 ` Luis R. Rodriguez
[not found] ` <200911031951.05235.bzolnier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-11-03 21:01 ` Gertjan van Wingerde
2009-11-04 15:15 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104083737.GA16978@elte.hu \
--to=mingo@elte.hu \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=ivdoorn@gmail.com \
--cc=jarkao2@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luis.f.correia@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).