From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC-PATCH] dhcp provisioning support in cxgb3i Date: Wed, 4 Nov 2009 11:09:04 -0800 Message-ID: <20091104110904.7ffc479b@s6510> References: <4AE995C4.4080909@chelsio.com> <4AEA04A4.1060800@cs.wisc.edu> <4AEA7870.4010804@chelsio.com> <4AEF6FC4.6060208@cs.wisc.edu> <4AF1C6C7.80103@chelsio.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Mike Christie , davem@davemloft.net, James Bottomley , Karen Xie , "open-iscsi@googlegroups.com" , LKML , "linux-scsi@vger.kernel.org" , netdev@vger.kernel.org, Rakesh Ranjan To: Rakesh Ranjan Return-path: In-Reply-To: <4AF1C6C7.80103@chelsio.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 04 Nov 2009 23:54:07 +0530 Rakesh Ranjan wrote: > Mike Christie wrote: > > Rakesh Ranjan wrote: > >> Mike Christie wrote: > >>> Rakesh Ranjan wrote: > >>>> Hi Mike, > >>>> > >>>> Herein attached patches for having dhcp provisioning support in > >>>> cxgb3i. I have added one new iscsi netlink message > >>>> ISCSI_UEVENT_REQ_IPCONF. > >>> > >>> Is the idea to have iscsid/uip send down this msg? > >>> > >>> Was it not possible to hook in more like how bnx2i does dhcp? > >> > >> yep, idea is to have iscsid send down ISCSI_UEVENT_REQ_IPCONF msg. > >> bnx2i approach in our case for at least T3 is not feasible. > >> > > > > I think adding DHCP in the kernel is getting a little crazy :) If we go > > down this path, I agree with the other person that stated it should at > > least be generic. > > Hi Mike, > > What do you mean be generic ? Do you want to have a generic interface > for DHCP handler that could be part of libiscsi and could be used by > other LLD's. Is there anyway to make existing code (in net/ipv4/ipconfig.c) more generic and useful for both?