From: Max Kellermann <mk@cm4all.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, jens.axboe@oracle.com,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH] tcp: set SPLICE_F_NONBLOCK after first buffer has been spliced
Date: Thu, 5 Nov 2009 11:57:49 +0100 [thread overview]
Message-ID: <20091105105749.GA4901@rabbit.intern.cm-ag> (raw)
In-Reply-To: <4AF2A929.3000201@gmail.com>
On 2009/11/05 11:30, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> I dont think this patch is correct. Could you describe your use case ?
See my second email, there's a demo source.
> If you dont want to block on output pipe, you should set this NONBLOCK
> flag before calling splice(SPLICE_F_NONBLOCK) syscall.
>
> ie : Use the socket in blocking mode, but output pipe in non-blocking mode.
Do you think that a splice() should block if the socket is readable
and the pipe is writable according to select()?
"The correct behavior would be to copy as much as possible, and return
without blocking. Block only if nothing can be transferred."
Do you disagree with that?
> Some application could have a thread working in full blocking mode,
> and have another thread reading the pipe (and eventually unblocking
> first thread)
I don't get this objection. Please explain.
next prev parent reply other threads:[~2009-11-05 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091105095947.32131.99768.stgit@rabbit.intern.cm-ag>
2009-11-05 10:30 ` [PATCH] tcp: set SPLICE_F_NONBLOCK after first buffer has been spliced Eric Dumazet
2009-11-05 10:57 ` Max Kellermann [this message]
2009-11-05 11:21 ` Eric Dumazet
2009-11-05 13:23 ` Max Kellermann
2009-11-05 14:11 ` Eric Dumazet
2009-11-05 14:33 ` Max Kellermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091105105749.GA4901@rabbit.intern.cm-ag \
--to=mk@cm4all.com \
--cc=eric.dumazet@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).