From: Simon Horman <horms@verge.net.au>
To: Roland Dreier <rdreier@cisco.com>
Cc: Liran Liss <liranl@mellanox.co.il>,
Or Gerlitz <or.gerlitz@gmail.com>,
Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
Tziporet Koren <tziporet@mellanox.co.il>
Subject: Re: [PATCH 19/25] mlx4: Randomizing mac addresses for slaves
Date: Fri, 6 Nov 2009 15:06:24 +1100 [thread overview]
Message-ID: <20091106040624.GA6629@verge.net.au> (raw)
In-Reply-To: <adabpjhc6az.fsf@roland-alpha.cisco.com>
On Thu, Nov 05, 2009 at 07:58:12AM -0800, Roland Dreier wrote:
>
> > This approach seems to be common practice now (e.g., drivers/net/igb/igb_main.c:1332).
> > In any case, the user can change the randomized mac.
>
> igb uses the full output of random_ether_addr(). I'd be fine with
> that. However setting the OUI means you only get 24 bits of randomness
> which makes a collision a lot more likely.
IIRC that was precisely why the OUI isn't used for the igb driver.
Perhaps some infrastructure (by which I mean a random_mac() function)
is warranted so at least this discussion can be concentrated around that
rather than repeating it for each driver that needs random mac addresses.
next prev parent reply other threads:[~2009-11-06 4:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 15:31 [PATCH 19/25] mlx4: Randomizing mac addresses for slaves Yevgeny Petrilin
[not found] ` <4AF19E69.8070605-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
2009-11-04 20:04 ` Roland Dreier
2009-11-04 21:33 ` Or Gerlitz
[not found] ` <15ddcffd0911041333l165ee274mfae3508a3db755e7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-05 13:38 ` Liran Liss
[not found] ` <2ED289D4E09FBD4D92D911E869B97FDD0166CA59-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org>
2009-11-05 15:58 ` Roland Dreier
2009-11-06 4:06 ` Simon Horman [this message]
[not found] ` <20091106040624.GA6629-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2009-11-06 6:08 ` Roland Dreier
[not found] ` <adaeiocyykl.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2009-11-06 7:07 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106040624.GA6629@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-rdma@vger.kernel.org \
--cc=liranl@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=or.gerlitz@gmail.com \
--cc=rdreier@cisco.com \
--cc=tziporet@mellanox.co.il \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).