From: David Miller <davem@davemloft.net>
To: xiaosuo@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] check the return value of ndo_select_queue()
Date: Mon, 09 Nov 2009 01:13:11 -0800 (PST) [thread overview]
Message-ID: <20091109.011311.203110058.davem@davemloft.net> (raw)
In-Reply-To: <412e6f7f0911090044v33c331edg6096c0f9b9db4143@mail.gmail.com>
From: Changli Gao <xiaosuo@gmail.com>
Date: Mon, 9 Nov 2009 16:44:05 +0800
> On Mon, Nov 9, 2009 at 3:26 PM, David Miller <davem@davemloft.net> wrote:
>> From: Changli Gao <xiaosuo@gmail.com>
>> Date: Mon, 09 Nov 2009 15:17:17 +0800
>>
>>> check the return value of ndo_select_queue()
>>>
>>> Check the return value of ndo_select_queue(). If the value isn't smaller
>>> than the real_num_tx_queues, print a warning message, and reset it to zero.
>>>
>>> Signed-off-by: Changli Gao <xiaosuo@gmail.com>
>>
>> Make it a WARN() so that it ends up in kerneloops.org
>>
> Like this?
> WARN(1, "%s selects TX queue %d, "
> "but real number of TX queues is %d\n",
> dev->name, queue_index, dev->real_num_tx_queues);
Yes, something like that.
next prev parent reply other threads:[~2009-11-09 9:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 7:17 [PATCH] check the return value of ndo_select_queue() Changli Gao
2009-11-09 7:26 ` David Miller
2009-11-09 8:44 ` Changli Gao
2009-11-09 9:13 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-11-09 9:34 Changli Gao
2009-11-09 9:50 ` Eric Dumazet
2009-11-09 10:02 ` Eric Dumazet
2009-11-09 11:29 ` Changli Gao
2009-11-10 1:42 Changli Gao
2009-11-10 3:43 ` Eric Dumazet
2009-11-13 22:09 ` David Miller
2009-11-14 0:50 Changli Gao
2009-11-14 7:54 ` Eric Dumazet
2009-11-14 12:14 ` Changli Gao
2009-11-14 12:37 ` Eric Dumazet
2009-11-16 6:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109.011311.203110058.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).