From: Evgeniy Polyakov <zbr@ioremap.net>
To: Gregory Haskins <ghaskins@novell.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
alacrityvm-devel@lists.sourceforge.net, herbert.xu@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] net: add dataref destructor to sk_buff
Date: Wed, 11 Nov 2009 00:40:48 +0300 [thread overview]
Message-ID: <20091110214048.GA20517@ioremap.net> (raw)
In-Reply-To: <4AF9B2A7.3050802@novell.com>
On Tue, Nov 10, 2009 at 01:36:23PM -0500, Gregory Haskins (ghaskins@novell.com) wrote:
> What about things like sendfile()? There has to be *some* way to
> synchronize with the io-completion event, I would think. Whatever that
> is, I'd like to tap into it.
All skb manipulation functions properly maintain data reference
counters, so pages will not be freed until all data is consumed.
But there is no guarantee that data placed in given page will not be
overwritten while page is being held somewhere in the stack.
Putting shared info destructor will allow to get notification, that
given shared info processing is over, i.e. that network stack does not
use data placed in shared info for given skb, but if it was copied or
VFS hold those pages, they may or may not be freed.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2009-11-10 21:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 14:20 [RFC PATCH] net: add dataref destructor to sk_buff Gregory Haskins
2009-11-06 5:08 ` David Miller
2009-11-06 16:08 ` Gregory Haskins
2009-11-10 11:53 ` Michael S. Tsirkin
2009-11-10 12:40 ` Gregory Haskins
2009-11-10 13:17 ` Michael S. Tsirkin
2009-11-10 14:11 ` Gregory Haskins
2009-11-10 14:36 ` Michael S. Tsirkin
2009-11-10 15:45 ` Gregory Haskins
2009-11-10 17:36 ` Michael S. Tsirkin
2009-11-10 18:36 ` Gregory Haskins
2009-11-10 21:40 ` Evgeniy Polyakov [this message]
2009-11-14 1:12 ` Herbert Xu
2009-11-14 1:33 ` Gregory Haskins
2009-11-14 2:21 ` Herbert Xu
2009-11-14 2:27 ` Gregory Haskins
2009-11-14 2:43 ` Herbert Xu
2009-11-14 2:45 ` Stephen Hemminger
2009-11-14 2:51 ` Herbert Xu
2009-11-14 5:27 ` Gregory Haskins
2009-11-16 19:59 ` Stephen Hemminger
2009-11-16 20:18 ` Gregory Haskins
2009-11-14 3:09 ` David Miller
2009-11-14 3:04 ` David Miller
2009-11-16 14:22 ` Gregory Haskins
2009-11-17 1:02 ` Herbert Xu
2009-11-17 12:33 ` Gregory Haskins
2009-11-16 17:08 ` Avi Kivity
2009-11-10 14:45 ` Michael S. Tsirkin
2009-11-10 15:47 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091110214048.GA20517@ioremap.net \
--to=zbr@ioremap.net \
--cc=alacrityvm-devel@lists.sourceforge.net \
--cc=ghaskins@novell.com \
--cc=herbert.xu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).