From: David Miller <davem@davemloft.net>
To: ben@decadent.org.uk
Cc: netdev@vger.kernel.org, 538372@bugs.debian.org
Subject: Re: [PATCH net-2.6] Revert "net: Support inclusion of <linux/socket.h> before <sys/socket.h>"
Date: Wed, 11 Nov 2009 19:09:24 -0800 (PST) [thread overview]
Message-ID: <20091111.190924.27363037.davem@davemloft.net> (raw)
In-Reply-To: <1257995115.2237.90.camel@localhost>
From: Ben Hutchings <ben@decadent.org.uk>
Date: Thu, 12 Nov 2009 03:05:15 +0000
> <linux/netlink.h> will not compile for userland, because
> <linux/socket.h> is no longer defining sa_family_t. For userland, this
> should be defined by <sys/socket.h>.
Still, you still essentially have two choices:
1) Tell userland, sorry you need to include sys/socket.h before
other "socket stuff" and that means linux/netlink.h in
particular
2) Put a !__KERNEL__ sys/socket.h include in there, but that's
asking for trouble.
Ok?
next prev parent reply other threads:[~2009-11-12 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 2:00 [PATCH net-2.6] Revert "net: Support inclusion of <linux/socket.h> before <sys/socket.h>" Ben Hutchings
2009-11-12 2:51 ` David Miller
2009-11-12 3:05 ` Ben Hutchings
2009-11-12 3:09 ` David Miller [this message]
2009-11-12 3:38 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111.190924.27363037.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=538372@bugs.debian.org \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).