From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: [PATCH 4/6] gianfar: Fix thinko in gfar_set_rx_stash_index() Date: Wed, 11 Nov 2009 03:11:07 +0300 Message-ID: <20091111001107.GD8817@oksana.dev.rtsoft.ru> References: <20091111001036.GA28576@oksana.dev.rtsoft.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Andy Fleming , Jon Loeliger , Kumar Gopalpet-B05799 , Lennert Buytenhek , Stephen Hemminger , netdev@vger.kernel.org, linuxppc-dev@ozlabs.org To: David Miller Return-path: Received: from imap.ru.mvista.com ([213.79.90.228]:1573 "EHLO buildserver.ru.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752017AbZKKALB (ORCPT ); Tue, 10 Nov 2009 19:11:01 -0500 Content-Disposition: inline In-Reply-To: <20091111001036.GA28576@oksana.dev.rtsoft.ru> Sender: netdev-owner@vger.kernel.org List-ID: We obviously want to write a modified 'temp' value back to the register, not the saved IRQ flags. Signed-off-by: Anton Vorontsov --- drivers/net/gianfar_sysfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/gianfar_sysfs.c b/drivers/net/gianfar_sysfs.c index 3724835..b31c9c8 100644 --- a/drivers/net/gianfar_sysfs.c +++ b/drivers/net/gianfar_sysfs.c @@ -186,7 +186,7 @@ static ssize_t gfar_set_rx_stash_index(struct device *dev, temp = gfar_read(®s->attreli); temp &= ~ATTRELI_EI_MASK; temp |= ATTRELI_EI(index); - gfar_write(®s->attreli, flags); + gfar_write(®s->attreli, temp); out: unlock_rx_qs(priv); -- 1.6.3.3