From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] s2io: fixing a ethtool test that is broken Date: Fri, 13 Nov 2009 19:36:00 -0800 (PST) Message-ID: <20091113.193600.215645997.davem@davemloft.net> References: <1257882263-7507-1-git-send-email-leitao@linux.vnet.ibm.com> <78C9135A3D2ECE4B8162EBDCE82CAD7705E74E6F@nekter> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: leitao@linux.vnet.ibm.com, netdev@vger.kernel.org, Sreenivasa.Honnur@neterion.com, Ramkrishna.Vepa@neterion.com To: Sivakumar.Subramani@neterion.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:46996 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755465AbZKNDfo (ORCPT ); Fri, 13 Nov 2009 22:35:44 -0500 In-Reply-To: <78C9135A3D2ECE4B8162EBDCE82CAD7705E74E6F@nekter> Sender: netdev-owner@vger.kernel.org List-ID: From: "Sivakumar Subramani" Date: Thu, 12 Nov 2009 13:59:53 -0500 > [Siva] Reviewed the patch. Please accept it. > > Acked-by: Sivakumar Subramani Please use reasonable mechanisms to reply to patches when you review them. Something in your mail client software or elsewhere has messed with the Message-Id and other elements of the email headers, and therefore the threading of messages so that patchwork and other tools can attach your reply to the patch posting itself simply do not work. This makes more work for me and I am not going to go searching for your replies by hand. So you should fix this because otherwise your review reply ACKs will get lost. Also you have this very non-standard way to attributing your content by adding these "[Name]" tags. Please don't do that, it is non-standard and therefore most people don't understand it at all. The normal email reply quoting mechanisms of your email client will let us know exactly what parts are written by you, and what parts are said by other people in quoted text. Thank you.