* Lots of tcp_recvmsg warnings in kerneloops list
@ 2009-11-13 17:10 Stephen Hemminger
2009-11-13 17:34 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2009-11-13 17:10 UTC (permalink / raw)
To: Ilpo Järvinen, David Miller; +Cc: netdev
Has anyone looked into this? Is there a fix? Should it be sent to stable?
http://kerneloops.org/searchweek.php?search=tcp_recvmsg
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Lots of tcp_recvmsg warnings in kerneloops list
2009-11-13 17:10 Lots of tcp_recvmsg warnings in kerneloops list Stephen Hemminger
@ 2009-11-13 17:34 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2009-11-13 17:34 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Ilpo Järvinen, David Miller, netdev, Herbert Xu
Stephen Hemminger a écrit :
> Has anyone looked into this? Is there a fix? Should it be sent to stable?
>
> http://kerneloops.org/searchweek.php?search=tcp_recvmsg
> --
Only debugging AFAIK, no discoveries yet.
commit c62f4c453ab4b0240ab857bfd089da2c01ad91e7
Author: Arjan van de Ven <arjan@linux.intel.com>
Date: Thu Oct 22 21:37:56 2009 -0700
net: use WARN() for the WARN_ON in commit b6b39e8f3fbbb
Commit b6b39e8f3fbbb (tcp: Try to catch MSG_PEEK bug) added a printk()
to the WARN_ON() that's in tcp.c. This patch changes this combination
to WARN(); the advantage of WARN() is that the printk message shows up
inside the message, so that kerneloops.org will collect the message.
In addition, this gets rid of an extra if() statement.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
commit b6b39e8f3fbbb31001b836afec87bcaf4811a7bf
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon Oct 19 19:41:06 2009 +0000
tcp: Try to catch MSG_PEEK bug
This patch tries to print out more information when we hit the
MSG_PEEK bug in tcp_recvmsg. It's been around since at least
2005 and it's about time that we finally fix it.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-13 17:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-13 17:10 Lots of tcp_recvmsg warnings in kerneloops list Stephen Hemminger
2009-11-13 17:34 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).