From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: [PATCH net-next] net: Optimize hard_start_xmit() return checking
Date: Sun, 15 Nov 2009 22:09:21 -0800 (PST) [thread overview]
Message-ID: <20091115.220921.65235245.davem@davemloft.net> (raw)
In-Reply-To: <20091115172012.GA2976@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Sun, 15 Nov 2009 18:20:12 +0100
> Recent changes in the TX error propagation require additional checking
> and masking of values returned from hard_start_xmit(), mainly to
> separate cases where skb was consumed. This aim can be simplified by
> changing the order of NETDEV_TX and NET_XMIT codes, because the latter
> are treated similarly to negative (ERRNO) values.
>
> After this change much simpler dev_xmit_complete() is also used in
> sch_direct_xmit(), so it is moved to netdevice.h.
>
> Additionally NET_RX definitions in netdevice.h are moved up from
> between TX codes to avoid confusion while reading the TX comment.
>
> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Looks good, applied, thanks!
prev parent reply other threads:[~2009-11-16 6:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-15 17:20 [PATCH net-next] net: Optimize hard_start_xmit() return checking Jarek Poplawski
2009-11-16 6:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091115.220921.65235245.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).