From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] rps: core implementation
Date: Mon, 16 Nov 2009 03:15:57 -0800 (PST) [thread overview]
Message-ID: <20091116.031557.61986462.davem@davemloft.net> (raw)
In-Reply-To: <4AFA73DA.30308@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 11 Nov 2009 09:20:42 +0100
> I think I'll try to extend your patches with TX completion recycling too.
>
> Ie record in skb the cpu number of original sender, and queue skb to
> remote queue for destruction (sock_wfree() call and expensive
> scheduler calls...)
>
> (This probably needs driver cooperation, instead of calling consume_skb(),
> use a different function)
You can add a new argument to consume_skb() which indicates to remote
schedule a local free.
I would also suggest to record the TX cpu at dev_hard_start_xmit()
time, rather than somewhere higher up such as the socket layer.
Otherwise you'll mess up routing/netfilter cases, and also mishandle
task migration.
But a very excellent idea.
next prev parent reply other threads:[~2009-11-16 11:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 6:53 [PATCH 1/2] rps: core implementation Tom Herbert
2009-11-11 8:20 ` Eric Dumazet
2009-11-11 16:28 ` Tom Herbert
2009-11-11 21:44 ` Andi Kleen
2009-11-12 2:32 ` David Miller
2009-11-16 11:15 ` David Miller [this message]
2009-11-11 16:49 ` Randy Dunlap
2009-11-11 21:43 ` Andi Kleen
2009-11-16 17:02 ` Tom Herbert
2009-11-19 10:08 ` Andi Kleen
2009-11-20 6:41 ` Tom Herbert
2009-11-20 6:49 ` Eric Dumazet
2009-11-12 20:23 ` Eric Dumazet
2009-11-16 11:19 ` David Miller
2009-11-16 16:43 ` Tom Herbert
2009-11-18 7:21 ` David Miller
2009-11-19 8:08 ` Jarek Poplawski
2009-11-20 22:52 ` David Miller
2009-11-17 21:32 ` Jarek Poplawski
2009-11-19 9:57 ` Jarek Poplawski
2009-11-20 17:08 ` Tom Herbert
2009-11-20 19:00 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116.031557.61986462.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).