From: David Miller <davem@davemloft.net>
To: peter.p.waskiewicz.jr@intel.com
Cc: leitao@linux.vnet.ibm.com, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] ixgbe: Fixing EEH handler to handle more than one error
Date: Mon, 16 Nov 2009 23:52:09 -0800 (PST) [thread overview]
Message-ID: <20091116.235209.227827212.davem@davemloft.net> (raw)
In-Reply-To: <Pine.WNT.4.64.0911161100030.16132@ppwaskie-MOBL2.amr.corp.intel.com>
From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Mon, 16 Nov 2009 11:01:13 -0800 (Pacific Standard Time)
> On Sun, 15 Nov 2009, David Miller wrote:
>
>> From: leitao@linux.vnet.ibm.com
>> Date: Tue, 10 Nov 2009 13:37:47 -0500
>>
>> > After commmit 4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff EEH breaks
>> > after the second error, since it calls pci_restore_state()
>> > but it returns 0, since pci->state_saved is false.
>> >
>> > So, this patch just call pci_save_state() after pci_restore_state().
>> >
>> > Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
>>
>> Intel folks, are you integrating or looking at this patch?
>
> This patch looks correct and makes sense to me. I'm going to ACK it now,
> but we'll still pull it in and test it. If we see any issues, we'll
> report them with possible fixes. But at this point, I think this patch is
> fine.
>
> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Applied, thanks.
prev parent reply other threads:[~2009-11-17 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 18:37 [PATCH] ixgbe: Fixing EEH handler to handle more than one error leitao
2009-11-16 6:16 ` David Miller
2009-11-16 19:01 ` Waskiewicz Jr, Peter P
2009-11-17 7:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091116.235209.227827212.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox