From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: eric.dumazet@gmail.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org
Subject: Re: PATCH net-next-2.6] linkwatch: linkwatch_forget_dev() to speedup device dismantle
Date: Tue, 17 Nov 2009 04:26:04 -0800 (PST) [thread overview]
Message-ID: <20091117.042604.99618154.davem@davemloft.net> (raw)
In-Reply-To: <20091116143917.14e4fa4f@s6510>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 16 Nov 2009 14:39:17 -0800
> On Mon, 16 Nov 2009 22:50:48 +0100
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Is this really valid?
The whole point in emitting the netif_carrier_off() is so
that applications see the event in userspace and therefore
can clean things up.
Sure, the kernel will no longer make the device visible, and therefore
the application can't operate on it any longer. But the application
is deserved of receiving the event anyways so that it can clean up
internal state and datastructures.
It seem to me that in this ->stop() case we'll now elide the event
emission, and I don't see how that can be right.
Really, the link watch stuff is just due for a redesign. I don't
think a simple hack is going to cut it this time, sorry Eric :-)
next prev parent reply other threads:[~2009-11-17 12:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 18:01 [RFC] dev->refcnt long term holder Eric Dumazet
2009-11-16 19:02 ` Stephen Hemminger
2009-11-16 19:54 ` Eric Dumazet
2009-11-17 8:30 ` David Miller
2009-11-17 8:37 ` Herbert Xu
2009-11-17 17:58 ` Stephen Hemminger
2009-11-17 19:18 ` David Miller
2009-11-16 21:50 ` PATCH net-next-2.6] linkwatch: linkwatch_forget_dev() to speedup device dismantle Eric Dumazet
2009-11-16 22:39 ` Stephen Hemminger
2009-11-17 12:26 ` David Miller [this message]
2009-11-17 12:31 ` Herbert Xu
2009-11-17 15:59 ` Eric Dumazet
2009-11-18 13:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117.042604.99618154.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).