From: Stephen Hemminger <shemminger@vyatta.com>
To: Rasesh Mody <rmody@brocade.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Adapter Linux Open SRC Team"
<adapter_linux_open_src_team@Brocade.COM>
Subject: Re: Subject: [PATCH 5/6] bna: Brocade 10Gb Ethernet device driver
Date: Tue, 17 Nov 2009 08:35:41 -0800 [thread overview]
Message-ID: <20091117083541.69e1e403@nehalam> (raw)
In-Reply-To: <CBE1CC7A31453F4CA63C13EFCE6A0F6C05BAD1DD1B@HQ-EXCH-7.corp.brocade.com>
On Tue, 17 Nov 2009 00:32:45 -0800
Rasesh Mody <rmody@brocade.com> wrote:
> > +
> > +#define wwn_t u64
> > +#define lun_t u64
>
> "No need for obfuscation, at least use a typedef."
>
> Hi Stephen,
>
> When using a typedef in place of #define for wwn_t we are getting check-patch warning. Is it advisable to use a typedef?
>
> - Rasesh
People disagree but my opinion on typedef's is they are ok as long as:
* a structure or integral type (ie not a pointer)
* encapsulates some semantic meaning (be32, spin_lock, irq_return)
* used in several places
* not just a data structure
The other option is just do a global replace.
What you were doing with #define is a weaker form of typedef. Which
is worse.
--
next prev parent reply other threads:[~2009-11-17 16:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 3:46 Subject: [PATCH 5/6] bna: Brocade 10Gb Ethernet device driver Rasesh Mody
2009-11-13 5:03 ` Stephen Hemminger
2009-11-13 5:07 ` Stephen Hemminger
2009-11-17 8:32 ` Rasesh Mody
2009-11-17 16:35 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-19 21:52 Rasesh Mody
2010-02-12 14:00 Rasesh Mody
2010-02-10 6:29 Rasesh Mody
2009-12-19 1:28 Debashis Dutt
2009-11-26 9:28 Debashis Dutt
2009-11-24 3:51 Rasesh Mody
2009-11-17 8:30 Rasesh Mody
2009-11-01 5:03 Rasesh Mody
2009-10-16 18:24 Rasesh Mody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117083541.69e1e403@nehalam \
--to=shemminger@vyatta.com \
--cc=adapter_linux_open_src_team@Brocade.COM \
--cc=netdev@vger.kernel.org \
--cc=rmody@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).