From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, herbert@gondor.apana.org.au,
netdev@vger.kernel.org
Subject: Re: [RFC] dev->refcnt long term holder
Date: Tue, 17 Nov 2009 09:58:46 -0800 [thread overview]
Message-ID: <20091117095846.6ef8b4f6@nehalam> (raw)
In-Reply-To: <20091117.003019.196504832.davem@davemloft.net>
On Tue, 17 Nov 2009 00:30:19 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> I'm trying to remember why we added this asynchronous link state event
> processing monster. It probably has something to do with needing a
> sleepable context. What's amusing is that linkwatch has repeatably
> caused RTNL deadlock issues over the years. :-)
I thought it was to handle:
1) carrier on old devices would bounce, so it provides ratelimiting
of state changes. Modern hardware and CPU's probably makes this a non-issue.
2) wasn't there some code path with device changes, hotplug, uevent and
udev that meant that we couldn't do notifiers immediately.
--
next prev parent reply other threads:[~2009-11-17 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 18:01 [RFC] dev->refcnt long term holder Eric Dumazet
2009-11-16 19:02 ` Stephen Hemminger
2009-11-16 19:54 ` Eric Dumazet
2009-11-17 8:30 ` David Miller
2009-11-17 8:37 ` Herbert Xu
2009-11-17 17:58 ` Stephen Hemminger [this message]
2009-11-17 19:18 ` David Miller
2009-11-16 21:50 ` PATCH net-next-2.6] linkwatch: linkwatch_forget_dev() to speedup device dismantle Eric Dumazet
2009-11-16 22:39 ` Stephen Hemminger
2009-11-17 12:26 ` David Miller
2009-11-17 12:31 ` Herbert Xu
2009-11-17 15:59 ` Eric Dumazet
2009-11-18 13:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117095846.6ef8b4f6@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).