From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
To: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Stephen Hemminger
<shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>,
Felix Fietkau <nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Subject: Re: [RFC] mac80211: disallow bridging managed/adhoc interfaces
Date: Tue, 17 Nov 2009 09:06:27 -0500 [thread overview]
Message-ID: <20091117140626.GE27743@tuxdriver.com> (raw)
In-Reply-To: <200911171504.54170.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
On Tue, Nov 17, 2009 at 03:04:52PM +0100, Michael Buesch wrote:
> On Tuesday 17 November 2009 14:46:25 Johannes Berg wrote:
> > --- wireless-testing.orig/net/bridge/br_if.c 2009-11-17 14:19:17.000000000 +0100
> > +++ wireless-testing/net/bridge/br_if.c 2009-11-17 14:20:03.000000000 +0100
> > @@ -390,6 +390,10 @@ int br_add_if(struct net_bridge *br, str
> > if (dev->br_port != NULL)
> > return -EBUSY;
> >
> > + /* No bridging devices that dislike that (e.g. wireless) */
> > + if (dev->priv_flags & IFF_DONT_BRIDGE)
> > + return -EINVAL;
>
> -EOPNOTSUPP?
> That would probably produce a better error message in userspace.
Yes, good point.
--
John W. Linville Someday the world will need a hero, and you
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-11-17 14:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 13:46 [RFC] mac80211: disallow bridging managed/adhoc interfaces Johannes Berg
[not found] ` <1258465585.3682.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-17 13:58 ` John W. Linville
2009-11-17 14:04 ` Johannes Berg
2009-11-17 14:04 ` Michael Buesch
[not found] ` <200911171504.54170.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-11-17 14:06 ` John W. Linville [this message]
2009-11-17 14:07 ` Johannes Berg
[not found] ` <1258466868.3682.13.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-17 16:37 ` Stephen Hemminger
2009-11-17 16:43 ` Johannes Berg
[not found] ` <1258476223.21197.0.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-17 17:04 ` Stephen Hemminger
2009-11-17 17:05 ` Johannes Berg
2009-11-17 20:41 ` Dan Williams
2009-11-17 20:48 ` [RFC v2] " Johannes Berg
[not found] ` <1258490898.21197.42.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-17 22:42 ` Julian Calaby
2009-11-17 22:46 ` Johannes Berg
2009-11-17 22:50 ` Julian Calaby
2009-11-17 22:42 ` Stephen Hemminger
2009-11-17 22:45 ` Johannes Berg
2009-11-18 1:59 ` Stefan Monnier
[not found] ` <jwvy6m4bnqp.fsf-monnier+gmane.linux.kernel.wireless.general-mXXj517/zsQ@public.gmane.org>
2009-11-18 2:59 ` John W. Linville
[not found] ` <20091118025920.GA4588-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-11-18 10:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117140626.GE27743@tuxdriver.com \
--to=linville-2xusbdqka4r54taoqtywwq@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org \
--cc=nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).