From: Stephen Hemminger <shemminger@vyatta.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: netdev <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [RFC v2] mac80211: disallow bridging managed/adhoc interfaces
Date: Tue, 17 Nov 2009 14:42:39 -0800 [thread overview]
Message-ID: <20091117144239.47930866@nehalam> (raw)
In-Reply-To: <1258490898.21197.42.camel@johannes.local>
On Tue, 17 Nov 2009 21:48:18 +0100
Johannes Berg <johannes@sipsolutions.net> wrote:
> A number of people have tried to add a wireless interface
> (in managed mode) to a bridge and then complained that it
> doesn't work. It cannot work, however, because in 802.11
> networks all packets need to be acknowledged and as such
> need to be sent to the right address. Promiscuous doesn't
> help here. The wireless address format used for these
> links has only space for three addresses, the
> * transmitter, which must be equal to the sender (origin)
> * receiver (on the wireless medium), which is the AP in
> the case of managed mode
> * the recipient (destination), which is on the APs local
> network segment
>
> In an IBSS, it is similar, but the receiver and recipient
> must match and the third address is used as the BSSID.
>
> To avoid such mistakes in the future, disallow adding a
> wireless interface to a bridge.
>
> Felix has recently added a four-address mode to the AP
> and client side that can be used (after negotiating that
> it is possible, which must happen out-of-band by setting
> up both sides) for bridging, so allow that case.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Looks good, maybe true four-address mode support will be available
more widely, and this will no longer be an issue.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
next prev parent reply other threads:[~2009-11-17 22:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 13:46 [RFC] mac80211: disallow bridging managed/adhoc interfaces Johannes Berg
[not found] ` <1258465585.3682.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-17 13:58 ` John W. Linville
2009-11-17 14:04 ` Johannes Berg
2009-11-17 14:04 ` Michael Buesch
[not found] ` <200911171504.54170.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2009-11-17 14:06 ` John W. Linville
2009-11-17 14:07 ` Johannes Berg
[not found] ` <1258466868.3682.13.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-17 16:37 ` Stephen Hemminger
2009-11-17 16:43 ` Johannes Berg
[not found] ` <1258476223.21197.0.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-17 17:04 ` Stephen Hemminger
2009-11-17 17:05 ` Johannes Berg
2009-11-17 20:41 ` Dan Williams
2009-11-17 20:48 ` [RFC v2] " Johannes Berg
[not found] ` <1258490898.21197.42.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-17 22:42 ` Julian Calaby
2009-11-17 22:46 ` Johannes Berg
2009-11-17 22:50 ` Julian Calaby
2009-11-17 22:42 ` Stephen Hemminger [this message]
2009-11-17 22:45 ` Johannes Berg
2009-11-18 1:59 ` Stefan Monnier
[not found] ` <jwvy6m4bnqp.fsf-monnier+gmane.linux.kernel.wireless.general-mXXj517/zsQ@public.gmane.org>
2009-11-18 2:59 ` John W. Linville
[not found] ` <20091118025920.GA4588-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-11-18 10:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091117144239.47930866@nehalam \
--to=shemminger@vyatta.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).