Netdev List
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net, shemminger@vyatta.com
Cc: netdev@vger.kernel.org, gospo@redhat.com,
	Mitch Williams <mitch.a.williams@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [RFC PATCH 4/4] igbvf: Make error message more enlightening
Date: Tue, 17 Nov 2009 13:51:24 -0800	[thread overview]
Message-ID: <20091117215123.15119.2904.stgit@localhost.localdomain> (raw)
In-Reply-To: <20091117214923.15119.98918.stgit@localhost.localdomain>

From: Williams, Mitch A <mitch.a.williams@intel.com>

The most likely cause of this error is that the PF interface is not up,
so let's make that very explicit.

Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---

 drivers/net/igbvf/netdev.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/igbvf/netdev.c b/drivers/net/igbvf/netdev.c
index fad7f34..a3c706c 100644
--- a/drivers/net/igbvf/netdev.c
+++ b/drivers/net/igbvf/netdev.c
@@ -2720,7 +2720,8 @@ static int __devinit igbvf_probe(struct pci_dev *pdev,
 	err = hw->mac.ops.reset_hw(hw);
 	if (err) {
 		dev_info(&pdev->dev,
-		         "PF still in reset state, assigning new address\n");
+			 "PF still in reset state, assigning new address. "
+			 "Is the PF interface up?\n");
 		random_ether_addr(hw->mac.addr);
 	} else {
 		err = hw->mac.ops.read_mac_addr(hw);


  parent reply	other threads:[~2009-11-17 21:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 21:50 [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters Jeff Kirsher
2009-11-17 21:50 ` [RFC PATCH 2/4] rtnetlink: Add support to rtnetlink for setting " Jeff Kirsher
2009-11-17 21:50 ` [RFC PATCH 3/4] igb: Add support to igb for setting MAC and VLAN filters to hardware queues Jeff Kirsher
2009-11-17 21:51 ` Jeff Kirsher [this message]
2009-11-18 19:53 ` [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters Ben Hutchings
2009-11-18 21:37   ` Williams, Mitch A
2009-11-18 23:14     ` Ben Hutchings
2009-11-18 23:33       ` Williams, Mitch A
2009-11-19 14:54         ` Ben Hutchings
2009-11-19 18:43           ` Williams, Mitch A
2009-11-19 18:58             ` Patrick McHardy
2009-11-19 19:12               ` Williams, Mitch A
2009-11-19 18:59             ` Ben Hutchings
2009-11-19 19:34               ` Williams, Mitch A
2009-11-23 13:22                 ` Ben Hutchings
2009-11-23 19:52                   ` Williams, Mitch A
2009-11-24 14:18                     ` Ben Hutchings
2009-11-24 16:14                       ` Williams, Mitch A
2009-11-30  6:03                     ` Simon Horman
2009-11-30 18:36                       ` Williams, Mitch A
2009-11-30 22:57                         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091117215123.15119.2904.stgit@localhost.localdomain \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=mitch.a.williams@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox