* [PATCH 8/16] drivers/net/smsc9420.c: remove exceptional & on function name
@ 2009-11-18 18:23 Julia Lawall
2009-11-18 18:51 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2009-11-18 18:23 UTC (permalink / raw)
To: Steve Glendinning, netdev, arnd, joe, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
In this file, function names are otherwise used as pointers without &.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/smsc9420.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/smsc9420.c b/drivers/net/smsc9420.c
index b4909a2..92e2bbe 100644
--- a/drivers/net/smsc9420.c
+++ b/drivers/net/smsc9420.c
@@ -1161,7 +1161,7 @@ static int smsc9420_mii_probe(struct net_device *dev)
phydev->phy_id);
phydev = phy_connect(dev, dev_name(&phydev->dev),
- &smsc9420_phy_adjust_link, 0, PHY_INTERFACE_MODE_MII);
+ smsc9420_phy_adjust_link, 0, PHY_INTERFACE_MODE_MII);
if (IS_ERR(phydev)) {
pr_err("%s: Could not attach to PHY\n", dev->name);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 8/16] drivers/net/smsc9420.c: remove exceptional & on function name
2009-11-18 18:23 [PATCH 8/16] drivers/net/smsc9420.c: remove exceptional & on function name Julia Lawall
@ 2009-11-18 18:51 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-11-18 18:51 UTC (permalink / raw)
To: julia; +Cc: steve.glendinning, netdev, arnd, joe, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:23:17 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-18 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-18 18:23 [PATCH 8/16] drivers/net/smsc9420.c: remove exceptional & on function name Julia Lawall
2009-11-18 18:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).