From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: stmmac patches...
Date: Thu, 19 Nov 2009 12:18:21 -0800 (PST) [thread overview]
Message-ID: <20091119.121821.51205410.davem@davemloft.net> (raw)
Please do not intermix coding style changes with bug
fixes.
In your second patch you change the indentation of
the arguments to ->init_rx_desc() in stmmac_suspend()
Not only is this inappropriate in a bug fix patch, it
is actually making the indentation incorrect. The
arguments should line up to the column after the
function argument set openning '(' on the previous
line.
Please fix this up and resubmit both of your patches.
Thank you.
next reply other threads:[~2009-11-19 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 20:18 David Miller [this message]
2009-11-20 7:19 ` stmmac patches Giuseppe CAVALLARO
2009-11-20 17:40 ` David Miller
2009-11-23 8:57 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119.121821.51205410.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).