From: David Miller <davem@davemloft.net>
To: David.Choi@Micrel.Com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
shemminger@vyatta.com, greg@kroah.com
Subject: Re: [PATCH 2.6.32-rc6] drivers/net: ks8851_mll ethernet network driver
Date: Thu, 19 Nov 2009 13:19:51 -0800 (PST) [thread overview]
Message-ID: <20091119.131951.26921972.davem@davemloft.net> (raw)
In-Reply-To: <20091119.122734.89781869.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 19 Nov 2009 12:27:34 -0800 (PST)
> From: "Choi, David" <David.Choi@Micrel.Com>
> Date: Tue, 17 Nov 2009 15:02:36 -0800
>
>> This patch is for ks8851 16bit MLL Ethernet network device driver in order to fix bugs and to enhance functions.
> ...
>> Signed-off-by: David J. Choi <david.choi@micrel.com>
>
> Applied.
Sorry I had to revert this, it adds new warnings to the
build.
You can't cast pointers to 'int' in order to print them,
that emits a warning on 64-bit systems because you're
truncating the top bits.
There is really no point in printing __iomem pointers,
those are very architecture specific. So is the IRQ
number.
I would just remove this part of your patch entirely
(don't forget to update the commit message to match).
Please fix this up and resubmit, thank you.
prev parent reply other threads:[~2009-11-19 21:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 23:02 [PATCH 2.6.32-rc6] drivers/net: ks8851_mll ethernet network driver Choi, David
2009-11-19 20:27 ` David Miller
2009-11-19 21:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091119.131951.26921972.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Choi@Micrel.Com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox