netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: william.allen.simpson@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next-2.6 PATCH v7 1/7 RFC] TCPCT part 1a: add request_values parameter for sending SYNACK
Date: Fri, 20 Nov 2009 09:20:17 -0800 (PST)	[thread overview]
Message-ID: <20091120.092017.54863878.davem@davemloft.net> (raw)
In-Reply-To: <4B06A3BD.8090804@gmail.com>

From: William Allen Simpson <william.allen.simpson@gmail.com>
Date: Fri, 20 Nov 2009 09:12:13 -0500

> -	if (tcp_v6_send_synack(sk, req))
> -		goto drop;
> +	if (tcp_v6_send_synack(sk, req, NULL)
> +	 || want_cookie)
> +		goto drop_and_free;

Please fix the coding style here, the "||" belongs at the end
of the previous line, not at the start of the next one.

Also, since it will all fit one one line anyways, please make
it that way:

	if (tcp_v6_send_synack(sk, req, NULL) || want_cookie)

Some of us still use 80x25 terminals to read code :-)

I think you've been asked to fix this specific kinds of cases up
before.

Thanks a lot.

  reply	other threads:[~2009-11-20 17:20 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20 14:04 [net-next-2.6 PATCH v7 0/7 RFC] TCPCT part 1: cookie option exchange William Allen Simpson
2009-11-20 14:12 ` [net-next-2.6 PATCH v7 1/7 RFC] TCPCT part 1a: add request_values parameter for sending SYNACK William Allen Simpson
2009-11-20 17:20   ` David Miller [this message]
2009-11-20 14:23 ` [net-next-2.6 PATCH v7 2/7 RFC] TCPCT part 1b: generate Responder Cookie secret William Allen Simpson
2009-11-20 17:22   ` David Miller
2009-11-20 20:47     ` Andi Kleen
2009-11-20 20:51       ` David Miller
2009-11-21 16:09         ` William Allen Simpson
2009-11-20 14:33 ` [net-next-2.6 PATCH v7 3/7 RFC] TCPCT part 1c: sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS William Allen Simpson
2009-11-20 17:24   ` David Miller
2009-11-21 16:51     ` William Allen Simpson
2009-11-21 19:18       ` David Miller
2009-11-21 19:22         ` David Miller
2009-11-22  4:40         ` William Allen Simpson
2009-11-20 14:38 ` [net-next-2.6 PATCH v7 4/7 RFC] TCPCT part 1d: define TCP cookie option, extend existing struct's William Allen Simpson
2009-11-20 17:25   ` David Miller
2009-11-22  4:53     ` William Allen Simpson
2009-11-20 14:48 ` [net-next-2.6 PATCH v7 5/7 RFC] TCPCT part 1e: implement socket option TCP_COOKIE_TRANSACTIONS William Allen Simpson
2009-11-20 17:26   ` David Miller
2009-11-20 20:54     ` Joe Perches
2009-11-22  6:25     ` William Allen Simpson
2009-11-22  7:10       ` Joe Perches
2009-11-23 11:16         ` William Allen Simpson
2009-11-23 17:25           ` Joe Perches
2009-11-23 17:49           ` David Miller
2009-11-23  0:31       ` David Miller
2009-11-23 18:28         ` [net-next-2.6 PATCH] net/ipv4: Move && and || to end of previous line Joe Perches
2009-11-23 18:31           ` David Miller
2009-11-23 18:38             ` Joe Perches
2009-11-23 18:41               ` David Miller
2009-11-29 21:00                 ` [PATCH net-next-2.6 PATCH] net: " Joe Perches
2009-11-30  0:55                   ` David Miller
2009-11-30 17:28                     ` Stephen Hemminger
2009-11-30 17:57                       ` Joe Perches
2009-11-30 21:00                       ` David Miller
2009-12-03 17:58                     ` [PATCH net-next-2.6] drivers/net: " Joe Perches
2009-12-03 20:40                       ` David Miller
2009-12-04 13:10                       ` Brice Goglin
2009-12-04 17:21                         ` Joe Perches
2009-12-05 12:43                           ` William Allen Simpson
2009-12-05 17:50                             ` Joe Perches
2009-12-05 22:05                               ` Jarek Poplawski
2009-12-06  3:36                               ` William Allen Simpson
2009-12-05 22:21                             ` David Miller
2009-12-06  3:00                               ` William Allen Simpson
2009-12-06 17:01                                 ` Jonathan Corbet
2009-12-04 22:42                         ` David Miller
2009-11-23 22:08           ` [net-next-2.6 PATCH] net/ipv4: " Ilpo Järvinen
2009-11-23 22:14             ` Joe Perches
2009-11-23 22:32               ` Ilpo Järvinen
2009-11-23 18:58         ` [net-next-2.6 PATCH] net/ipv6: " Joe Perches
2009-11-24 22:53           ` David Miller
2009-11-23 19:49         ` [net-next-2.6 PATCH] net/ipv[46]/netfilter: " Joe Perches
2009-11-23 22:20           ` Patrick McHardy
2009-11-20 14:55 ` [net-next-2.6 PATCH v7 6/7 RFC] TCPCT part 1f: Initiator Cookie => Responder William Allen Simpson
2009-11-20 17:29   ` David Miller
2009-11-20 15:06 ` [net-next-2.6 PATCH v7 7/7 RFC] TCPCT part 1g: Responder Cookie => Initiator William Allen Simpson
2009-11-20 17:31   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091120.092017.54863878.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=william.allen.simpson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).