netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Rasesh Mody <rmody@brocade.com>
Cc: <netdev@vger.kernel.org>, <adapter_linux_open_src_team@brocade.com>
Subject: Re: Subject: [PATCH 2/6] bna: Brocade 10Gb Ethernet device driver
Date: Mon, 23 Nov 2009 20:26:20 -0800	[thread overview]
Message-ID: <20091123202620.5ead8af2@s6510> (raw)
In-Reply-To: <200911240351.nAO3p1AY025627@blc-10-10.brocade.com>

On Mon, 23 Nov 2009 19:51:01 -0800
Rasesh Mody <rmody@brocade.com> wrote:

> +/**
> + *  bna_rxf_frame_stats_get()
> + *
> + *  For RxF "rxf_id", it loads frame statistics into "stats_ptr".
> + *
> + * @param[in]  dev     - pointer to BNA device structure
> + * @param[in]  rxf_id  - rx-function ID.
> + * @param[out]  stats_ptr - pointer to stats structure to fill
> + *
> + * @return BNA_OK   - successful
> + * @return BNA_FAIL - failed on sanity checks.
> + */
> +void bna_rxf_frame_stats_get(struct bna_dev *dev, unsigned int rxf_id,
> +	struct bna_stats_rxf **stats_ptr)
> +{
> +
> +	BNA_ASSERT(rxf_id < BNA_RXF_ID_MAX);
> +
> +	*stats_ptr = &dev->stats.rxf_stats[rxf_id];
> +}

20 lines to do the work of 1!

  parent reply	other threads:[~2009-11-24  4:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-24  3:51 Subject: [PATCH 2/6] bna: Brocade 10Gb Ethernet device driver Rasesh Mody
2009-11-24  4:21 ` Stephen Hemminger
2009-11-24  4:22 ` Stephen Hemminger
2009-11-24  4:23 ` Stephen Hemminger
2009-11-24  4:24 ` Stephen Hemminger
2009-11-26  9:01   ` Debashis Dutt
2009-11-24  4:26 ` Stephen Hemminger [this message]
2009-11-24  4:27 ` Stephen Hemminger
2009-11-24  4:28 ` Stephen Hemminger
2009-11-26  8:58   ` Debashis Dutt
  -- strict thread matches above, loose matches on Subject: below --
2010-02-19 21:52 Rasesh Mody
2010-02-22 12:36 ` Stanislaw Gruszka
2010-02-12 14:00 Rasesh Mody
2010-02-10  6:29 Rasesh Mody
2009-12-19  1:28 Debashis Dutt
2009-12-19  2:19 ` Ben Hutchings
2009-11-26  9:28 Debashis Dutt
2009-11-17  8:30 Rasesh Mody
2009-11-17  9:00 ` David Miller
2009-11-13  3:46 Rasesh Mody
2009-11-13  5:08 ` Stephen Hemminger
2009-11-01  5:03 Rasesh Mody
2009-11-01 19:23 ` Stephen Hemminger
2009-11-01 19:25 ` Stephen Hemminger
2009-10-16 18:24 Rasesh Mody
2009-10-16 20:31 ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091123202620.5ead8af2@s6510 \
    --to=shemminger@vyatta.com \
    --cc=adapter_linux_open_src_team@brocade.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmody@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).