From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com
Subject: Re: [PATCH 03/12] sfc: Turn pause frame generation on and off at the MAC, not the RX FIFO
Date: Sun, 29 Nov 2009 16:47:50 -0800 (PST) [thread overview]
Message-ID: <20091129.164750.226469571.davem@davemloft.net> (raw)
In-Reply-To: <1259502138.3709.42.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Sun, 29 Nov 2009 13:42:18 +0000
> Pause frame generation is gated by both RX_XOFF_MAC_EN and an enable
> bit in each MAC. RX_XOFF_MAC_EN bit always reads back as 0 so we need
> to set it correctly every time we modify RX_CFG_REG. Simplify this by
> always setting it to 1 and only changing the enable bits in the MACs.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied.
prev parent reply other threads:[~2009-11-30 0:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 13:42 [PATCH 03/12] sfc: Turn pause frame generation on and off at the MAC, not the RX FIFO Ben Hutchings
2009-11-30 0:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091129.164750.226469571.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).