From: David Miller <davem@davemloft.net>
To: eric.y.miao@gmail.com
Cc: linux@arm.linux.org.uk, nico@fluxnic.net, netdev@vger.kernel.org
Subject: Re: [PATCH] NET: smc91x: Fix irq flags
Date: Sun, 29 Nov 2009 23:47:58 -0800 (PST) [thread overview]
Message-ID: <20091129.234758.147268701.davem@davemloft.net> (raw)
In-Reply-To: <f17812d70911280715v50f48298rd5a469e393235a95@mail.gmail.com>
From: Eric Miao <eric.y.miao@gmail.com>
Date: Sat, 28 Nov 2009 23:15:13 +0800
> On Sat, Nov 28, 2009 at 6:13 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>> smc91x.h defines SMC_IRQ_FLAGS to be -1 when it wants the interrupt
>> flags to be taken from the resource structure. ^[,A ^[(BHowever, d280ead
>> changed this to checking for non-zero resource flags.
>>
>> Unfortunately, this means that on some platforms, we end up passing
>> '-1' to request_irq rather than the desired result. ^[,A ^[(BCombine the two
>> conditions into one so that the IRQ flags are taken from the resource
>> if either SMC_IRQ_FLAGS is -1 or the resource flags specify an
>> interrupt trigger.
>>
>> This restores network on at least the Versatile platform.
>>
>> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Acked-by: Eric Miao <eric.y.miao@gmail.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2009-11-30 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-28 10:13 [PATCH] NET: smc91x: Fix irq flags Russell King - ARM Linux
2009-11-28 15:15 ` Eric Miao
2009-11-30 7:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091129.234758.147268701.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.y.miao@gmail.com \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox