From: Jarek Poplawski <jarkao2@gmail.com>
To: Philippe De Muyter <phdm@macqel.be>
Cc: grundler@parisc-linux.org, kyle@mcmartin.ca,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: tulip : kernel BUG in tulip_up/tulip_resume
Date: Sun, 29 Nov 2009 12:36:59 +0100 [thread overview]
Message-ID: <20091129113659.GA2971@ami.dom.local> (raw)
In-Reply-To: <20091129001710.GA4055@ami.dom.local>
On Sun, Nov 29, 2009 at 01:17:10AM +0100, Jarek Poplawski wrote:
> Philippe De Muyter wrote, On 11/08/2009 11:33 PM:
> > Does someone know what could be wrong and have a fix or should I look myself ?
>
> Don't know, guess only...
...And maybe a second guess btw. (to try together or separate).
Jarek P.
---
diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 6b2330e..fd32601 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1749,9 +1749,9 @@ static int tulip_suspend (struct pci_dev *pdev, pm_message_t state)
if (!netif_running(dev))
goto save_state;
+ netif_device_detach(dev);
tulip_down(dev);
- netif_device_detach(dev);
free_irq(dev->irq, dev);
save_state:
next prev parent reply other threads:[~2009-11-29 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 16:57 [PATCH] tulip : fix 21142 with 10Mbps without negotiation Philippe De Muyter
2009-01-30 21:49 ` David Miller
[not found] ` <20090129210701.GA8092@frolo.macqel>
2009-11-08 22:33 ` tulip : kernel BUG in tulip_up/tulip_resume Philippe De Muyter
2009-11-21 19:10 ` David Miller
2009-11-29 0:17 ` Jarek Poplawski
2009-11-29 11:36 ` Jarek Poplawski [this message]
2009-12-03 6:25 ` David Miller
2009-12-03 8:47 ` Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091129113659.GA2971@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=grundler@parisc-linux.org \
--cc=kyle@mcmartin.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).