* [patch] drop chan->wsem on error path
@ 2009-11-29 16:02 Dan Carpenter
2009-11-30 7:44 ` Jan Kasprzak
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2009-11-29 16:02 UTC (permalink / raw)
To: kas; +Cc: netdev
The other paths all drop chan->wsem. This was found by a static
checker (smatch).
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/net/wan/cosa.c 2009-11-29 16:38:42.000000000 +0200
+++ devel/drivers/net/wan/cosa.c 2009-11-29 16:43:39.000000000 +0200
@@ -907,6 +907,7 @@ static ssize_t cosa_write(struct file *f
current->state = TASK_RUNNING;
chan->tx_status = 1;
spin_unlock_irqrestore(&cosa->lock, flags);
+ up(&chan->wsem);
return -ERESTARTSYS;
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] drop chan->wsem on error path
2009-11-29 16:02 [patch] drop chan->wsem on error path Dan Carpenter
@ 2009-11-30 7:44 ` Jan Kasprzak
2009-11-30 8:07 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kasprzak @ 2009-11-30 7:44 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev
Dan Carpenter wrote:
: The other paths all drop chan->wsem. This was found by a static
: checker (smatch).
You are right, thanks!
:
: Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
: --- orig/drivers/net/wan/cosa.c 2009-11-29 16:38:42.000000000 +0200
: +++ devel/drivers/net/wan/cosa.c 2009-11-29 16:43:39.000000000 +0200
: @@ -907,6 +907,7 @@ static ssize_t cosa_write(struct file *f
: current->state = TASK_RUNNING;
: chan->tx_status = 1;
: spin_unlock_irqrestore(&cosa->lock, flags);
: + up(&chan->wsem);
: return -ERESTARTSYS;
: }
: }
--
| Jan "Yenya" Kasprzak <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839 Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/ Journal: http://www.fi.muni.cz/~kas/blog/ |
Please don't top post and in particular don't attach entire digests to your
mail or we'll all soon be using bittorrent to read the list. --Alan Cox
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] drop chan->wsem on error path
2009-11-30 7:44 ` Jan Kasprzak
@ 2009-11-30 8:07 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-11-30 8:07 UTC (permalink / raw)
To: kas; +Cc: error27, netdev
From: Jan Kasprzak <kas@fi.muni.cz>
Date: Mon, 30 Nov 2009 08:44:18 +0100
> Dan Carpenter wrote:
> : The other paths all drop chan->wsem. This was found by a static
> : checker (smatch).
>
> You are right, thanks!
>
> :
> : Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Acked-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
Patch applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-30 8:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-29 16:02 [patch] drop chan->wsem on error path Dan Carpenter
2009-11-30 7:44 ` Jan Kasprzak
2009-11-30 8:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).