From: Simon Horman <horms@verge.net.au>
To: "Williams, Mitch A" <mitch.a.williams@intel.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"shemminger@vyatta.com" <shemminger@vyatta.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters
Date: Mon, 30 Nov 2009 17:03:23 +1100 [thread overview]
Message-ID: <20091130060323.GA17989@verge.net.au> (raw)
In-Reply-To: <EA929A9653AAE14F841771FB1DE5A1365FA6A9617F@rrsmsx501.amr.corp.intel.com>
On Mon, Nov 23, 2009 at 12:52:48PM -0700, Williams, Mitch A wrote:
> >From: Ben Hutchings [mailto:bhutchings@solarflare.com]
> >Sent: Monday, November 23, 2009 5:23 AM
> [snip]
>
> >
> >How does this interact with use of multiple queues within a single
> >function? Are the specified queue numbers really interpreted as RX
> >queue indices or as function numbers?
> >
> >Ben.
>
> Yeah, that is ambiguous. Would it be better if we changed the name of the parameter to 'vf' instead of 'queue' to make it explicit?
>
> This would give us:
> $ ip link set eth1 vf 1 mac <blah>
>
> The issue of which VF goes with which PF device can be deduced in
> userspace via sysfs.
Does this mean that the configuration of filtering for a VF needs
to be done where the interface for the VF exists - e.g. in a KVM
guest/Xen domU?
In terms of dealing with interfaces and the way that tools such as ip work
that makes a lot of sense. But I wonder if it actually makes more sense
from an administrative point of view to have this configuration go through
the PF - e.g. the KVM host/Xen domO.
next prev parent reply other threads:[~2009-11-30 6:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 21:50 [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters Jeff Kirsher
2009-11-17 21:50 ` [RFC PATCH 2/4] rtnetlink: Add support to rtnetlink for setting " Jeff Kirsher
2009-11-17 21:50 ` [RFC PATCH 3/4] igb: Add support to igb for setting MAC and VLAN filters to hardware queues Jeff Kirsher
2009-11-17 21:51 ` [RFC PATCH 4/4] igbvf: Make error message more enlightening Jeff Kirsher
2009-11-18 19:53 ` [RFC PATCH 1/4] net: Add support to netdev ops for changing hardware queue MAC and VLAN filters Ben Hutchings
2009-11-18 21:37 ` Williams, Mitch A
2009-11-18 23:14 ` Ben Hutchings
2009-11-18 23:33 ` Williams, Mitch A
2009-11-19 14:54 ` Ben Hutchings
2009-11-19 18:43 ` Williams, Mitch A
2009-11-19 18:58 ` Patrick McHardy
2009-11-19 19:12 ` Williams, Mitch A
2009-11-19 18:59 ` Ben Hutchings
2009-11-19 19:34 ` Williams, Mitch A
2009-11-23 13:22 ` Ben Hutchings
2009-11-23 19:52 ` Williams, Mitch A
2009-11-24 14:18 ` Ben Hutchings
2009-11-24 16:14 ` Williams, Mitch A
2009-11-30 6:03 ` Simon Horman [this message]
2009-11-30 18:36 ` Williams, Mitch A
2009-11-30 22:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130060323.GA17989@verge.net.au \
--to=horms@verge.net.au \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).