From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: xiaosuo@gmail.com, hadi@cyberus.ca, netdev@vger.kernel.org,
martin.devera@cdi.cz
Subject: Re: [PATCH] sch_htb: ix the deficit overflows
Date: Wed, 2 Dec 2009 10:32:04 +0000 [thread overview]
Message-ID: <20091202103204.GA7724@ff.dom.local> (raw)
In-Reply-To: <20091202.012017.39623676.davem@davemloft.net>
On Wed, Dec 02, 2009 at 01:20:17AM -0800, David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Mon, 30 Nov 2009 11:10:20 +0000
>
> > On Mon, Nov 30, 2009 at 12:26:33PM +0800, Changli Gao wrote:
> >> And
> >> if we use IMQ to shape traffic, the skb will be defragmented by
> >> conntrack, and its size will be larger than MTU.
> >
> > IMQ is a very nice thing, but it's considered broken as well, so it
> > can't be the reason for changing HTB.
>
> If you don't like IMQ, fine. Simply consider TSO and GSO as another
> set of mechanisms that can introduce this condition.
>
> Because we toss large SKBs all over the strack quite freely,
> protections like those suggested by Changli make perfect sense.
>
> We really don't have an MTU for packets within our stack any more.
> The code, by default, need to be able to handle anything.
Alas, an MTU is still a crucial parameter for some schedulers. Anyway,
I hope Changli wasn't mislead to treat my private opinions in this or
any other thread as decisive. Otherwise, I'm sorry.
Jarek P.
next prev parent reply other threads:[~2009-12-02 10:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 8:14 [PATCH] sch_htb: ix the deficit overflows Changli Gao
2009-11-28 0:04 ` Jarek Poplawski
2009-11-30 4:26 ` Changli Gao
2009-11-30 11:10 ` Jarek Poplawski
2009-12-01 2:32 ` Changli Gao
2009-12-01 8:01 ` Jarek Poplawski
2009-12-01 8:43 ` Jarek Poplawski
2009-12-01 9:18 ` Changli Gao
2009-12-01 9:39 ` Jarek Poplawski
2009-12-01 19:12 ` Jarek Poplawski
2009-12-01 19:18 ` Jarek Poplawski
2009-12-02 9:20 ` David Miller
2009-12-02 10:32 ` Jarek Poplawski [this message]
2009-12-02 11:07 ` Martin Devera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091202103204.GA7724@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=martin.devera@cdi.cz \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).