From: David Miller <davem@davemloft.net>
To: oliver@neukum.org
Cc: torgny.johansson@ericsson.com, david-b@pacbell.net,
netdev@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [patch]reset_resume for cdc-ether
Date: Thu, 03 Dec 2009 12:31:50 -0800 (PST) [thread overview]
Message-ID: <20091203.123150.182603807.davem@davemloft.net> (raw)
In-Reply-To: <200912031402.48289.oliver@neukum.org>
From: Oliver Neukum <oliver@neukum.org>
Date: Thu, 3 Dec 2009 14:02:48 +0100
> Am Donnerstag, 3. Dezember 2009 11:14:56 schrieb David Miller:
>
>> It doesn't apply to my tree still:
>
> And this is autosuspend.
Oliver, when you send two patches to the same files you
have to make it so that when the first one is applied
the second one applies cleanly on top. That's not what
happens here:
davem@sunset:~/src/GIT/net-next-2.6$ git am --signoff bundle-732.mbox
Applying: cdc-ether: Implement reset_resume()
Applying: usbnet & cdc-ether: autosuspend for online devices
error: patch failed: drivers/net/usb/cdc_ether.c:411
error: drivers/net/usb/cdc_ether.c: patch does not apply
Patch failed at 0002 usbnet & cdc-ether: autosuspend for online devices
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Also, please compose your patch emails correctly, I always have
to edit them.
The commit message header line should be your subject (with
something like "[PATCH 01/02] " or similar prefixed).
The body of your email should be the commit message contents
and then the patch.
If you want to make some extra comments that are not meant to
go into the commit message, put a line with just "---" after
the commit message (and before the patch), and then add what
you want to say.
Finally, please capitalize and properly spell words when appropriate.
F.e. "imlement" should be "Implement" in the commit header line of the
reset_resume() commit.
next prev parent reply other threads:[~2009-12-03 20:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 10:59 [patch]reset_resume for cdc-ether Oliver Neukum
2009-11-29 8:18 ` David Miller
2009-12-03 6:16 ` David Miller
[not found] ` <20091202.221627.133392199.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-12-03 6:22 ` David Miller
[not found] ` <20091202.222254.61468873.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-12-03 9:56 ` Oliver Neukum
2009-12-03 10:14 ` David Miller
2009-12-03 10:26 ` Oliver Neukum
2009-12-03 10:33 ` David Miller
2009-12-03 13:01 ` Oliver Neukum
2009-12-03 13:02 ` Oliver Neukum
2009-12-03 20:31 ` David Miller [this message]
[not found] ` <20091203.123150.182603807.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-12-03 21:11 ` Oliver Neukum
2009-12-03 21:12 ` David Miller
[not found] ` <200912031056.17103.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-12-03 14:52 ` Torgny Johansson
2009-12-03 10:02 ` Oliver Neukum
[not found] ` <200912031102.56903.oliver-GvhC2dPhHPQdnm+yROfE0A@public.gmane.org>
2009-12-03 10:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203.123150.182603807.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=torgny.johansson@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox