From: David Miller <davem@davemloft.net>
To: Tristram.Ha@Micrel.Com
Cc: ben@simtec.co.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.32 3/3] net: Make ks8851 snl work under Beagle Zippy combo board
Date: Thu, 03 Dec 2009 16:05:11 -0800 (PST) [thread overview]
Message-ID: <20091203.160511.211490797.davem@davemloft.net> (raw)
In-Reply-To: <14385191E87B904DBD836449AA30269D021A42@MORGANITE.micrel.com>
From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
Date: Thu, 3 Dec 2009 13:30:03 -0800
> From: Tristram Ha <Tristram.Ha@micrel.com>
>
> The Micrel KSZ8851 SNL Ethernet chip is used in the OMAP Beagle Zippy combo board. Requesting interrupt using level triggering flag hangs the system because the interrupt handling routine is called continually. Using edge triggering avoids this problem. As a result, disabling interrupt may not be necessary.
>
> Signed-off-by: Tristram Ha <Tristram.Ha@micrel.com>
You say "may not be necessary", do you actually know for sure?
This seems questionable, if the interrupt disabling was there
for a reason what has changed to make it such that it is no
longer necessary?
next prev parent reply other threads:[~2009-12-04 0:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 21:30 [PATCH 2.6.32 3/3] net: Make ks8851 snl work under Beagle Zippy combo board Ha, Tristram
2009-12-04 0:05 ` David Miller [this message]
2009-12-04 1:17 ` Ha, Tristram
2009-12-21 22:07 ` Ha, Tristram
2009-12-04 10:20 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203.160511.211490797.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Tristram.Ha@Micrel.Com \
--cc=ben@simtec.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).