Re: ipv4 05/05: add sysctl to accept packets with local source addresses

Patrick McHardy
2009-12-04T07:55:46Z

Eric W. Biederman wrote:
> Patrick McHardy <kaber@trash.net> writes:
>
>> commit 8ec1e0ebe26087bfc5c0394ada5feb5758014fc8
>> Author: Patrick McHardy <kaber@trash.net>
>> Date: Thu Dec 3 12:16:35 2009 +0100
>>
>> ipv4: add sysctl to accept packets with local source addresses
>>
>> Change fib_validate_source() to accept packets with a local source address when
>> the "accept_local" sysctl is set for the incoming inet device. Combined with the
>> previous patches, this allows to communicate between multiple local interfaces
>> over the wire.
>>
>> Signed-off-by: Patrick McHardy <kaber@trash.net>
>>
>
> Obligatory grumble. New binary sysctl. Grumble.
>
> Honestly this might be the one new sysctl that doesn't conflict with
> my sysctl tree. That should merge to Linus sometime this merge cycle
> which will stop exporting this to userspace. So I don't have any
> real complaints. Grumble.
>
> This overloading of sysctl.h for the binary sysctl numbers and
> the index into the perdevice sysctls is something we should probably
> change at some point to keep maintenance a little less confusing.

Yes, unfortunately its currently not possible to add inetdev sysctls
without allocating new numbers.